From: Markus Elfring <elfr...@users.sourceforge.net> Date: Mon, 1 Jul 2019 17:10:13 +0200
A single character (depending on a condition check) should be put into a sequence. Thus use the corresponding function “seq_putc”. This issue was detected by using the Coccinelle software. Signed-off-by: Markus Elfring <elfr...@users.sourceforge.net> --- drivers/md/raid1.c | 4 ++-- drivers/md/raid10.c | 3 ++- drivers/md/raid5.c | 3 ++- 3 files changed, 6 insertions(+), 4 deletions(-) diff --git a/drivers/md/raid1.c b/drivers/md/raid1.c index 34e26834ad28..769d79a1d2cf 100644 --- a/drivers/md/raid1.c +++ b/drivers/md/raid1.c @@ -1597,7 +1597,7 @@ static void raid1_status(struct seq_file *seq, struct mddev *mddev) rcu_read_lock(); for (i = 0; i < conf->raid_disks; i++) { struct md_rdev *rdev = rcu_dereference(conf->mirrors[i].rdev); - seq_printf(seq, "%s", - rdev && test_bit(In_sync, &rdev->flags) ? "U" : "_"); + seq_putc(seq, + rdev && test_bit(In_sync, &rdev->flags) ? 'U' : '_'); } rcu_read_unlock(); diff --git a/drivers/md/raid10.c b/drivers/md/raid10.c index 8a1354a08a1a..4e7da5dcbf86 100644 --- a/drivers/md/raid10.c +++ b/drivers/md/raid10.c @@ -1572,6 +1572,7 @@ static void raid10_status(struct seq_file *seq, struct mddev *mddev) rcu_read_lock(); for (i = 0; i < conf->geo.raid_disks; i++) { struct md_rdev *rdev = rcu_dereference(conf->mirrors[i].rdev); - seq_printf(seq, "%s", rdev && test_bit(In_sync, &rdev->flags) ? "U" : "_"); + seq_putc(seq, + rdev && test_bit(In_sync, &rdev->flags) ? 'U' : '_'); } rcu_read_unlock(); diff --git a/drivers/md/raid5.c b/drivers/md/raid5.c index 3de4e13bde98..4b0e93869801 100644 --- a/drivers/md/raid5.c +++ b/drivers/md/raid5.c @@ -7510,6 +7510,7 @@ static void raid5_status(struct seq_file *seq, struct mddev *mddev) rcu_read_lock(); for (i = 0; i < conf->raid_disks; i++) { struct md_rdev *rdev = rcu_dereference(conf->disks[i].rdev); - seq_printf (seq, "%s", rdev && test_bit(In_sync, &rdev->flags) ? "U" : "_"); + seq_putc(seq, + rdev && test_bit(In_sync, &rdev->flags) ? 'U' : '_'); } rcu_read_unlock(); -- 2.22.0