Re: [PATCH] md: dm-verity: Fix to avoid a deadlock in dm-bufio

2013-03-13 Thread Paul Taysom
On Tue, Mar 12, 2013 at 7:46 AM, Paul Taysom wrote: > Looks good to me. > > On Tue, Mar 5, 2013 at 3:30 PM, Paul Taysom wrote: >> seconds_kernel_to_login: 8.17s >> Passed all my other tests >> >> On Mon, Mar 4, 2013 at 2:15 PM, Mikulas Patocka wrote: >>> >>> >>> On Mon, 4 Mar 2013, Paul Taysom

Re: [PATCH] md: dm-verity: Fix to avoid a deadlock in dm-bufio

2013-03-13 Thread Paul Taysom
On Tue, Mar 12, 2013 at 7:46 AM, Paul Taysom tay...@google.com wrote: Looks good to me. On Tue, Mar 5, 2013 at 3:30 PM, Paul Taysom tay...@google.com wrote: seconds_kernel_to_login: 8.17s Passed all my other tests On Mon, Mar 4, 2013 at 2:15 PM, Mikulas Patocka mpato...@redhat.com wrote:

Re: [PATCH] md: dm-verity: Fix to avoid a deadlock in dm-bufio

2013-03-12 Thread Paul Taysom
Looks good to me. On Tue, Mar 5, 2013 at 3:30 PM, Paul Taysom wrote: > seconds_kernel_to_login: 8.17s > Passed all my other tests > > On Mon, Mar 4, 2013 at 2:15 PM, Mikulas Patocka wrote: >> >> >> On Mon, 4 Mar 2013, Paul Taysom wrote: >> >>> On Mon, Mar 4, 2013 at 9:42 AM, Alasdair G Kergon

Re: [PATCH] md: dm-verity: Fix to avoid a deadlock in dm-bufio

2013-03-12 Thread Paul Taysom
Looks good to me. On Tue, Mar 5, 2013 at 3:30 PM, Paul Taysom tay...@google.com wrote: seconds_kernel_to_login: 8.17s Passed all my other tests On Mon, Mar 4, 2013 at 2:15 PM, Mikulas Patocka mpato...@redhat.com wrote: On Mon, 4 Mar 2013, Paul Taysom wrote: On Mon, Mar 4, 2013 at 9:42

Re: [PATCH] md: dm-verity: Fix to avoid a deadlock in dm-bufio

2013-03-05 Thread Paul Taysom
seconds_kernel_to_login: 8.17s Passed all my other tests On Mon, Mar 4, 2013 at 2:15 PM, Mikulas Patocka wrote: > > > On Mon, 4 Mar 2013, Paul Taysom wrote: > >> On Mon, Mar 4, 2013 at 9:42 AM, Alasdair G Kergon wrote: >> > On Mon, Mar 04, 2013 at 08:45:48AM -0800, Paul Taysom wrote: >> >> @@

Re: [PATCH] md: dm-verity: Fix to avoid a deadlock in dm-bufio

2013-03-05 Thread Paul Taysom
seconds_kernel_to_login: 8.17s Passed all my other tests On Mon, Mar 4, 2013 at 2:15 PM, Mikulas Patocka mpato...@redhat.com wrote: On Mon, 4 Mar 2013, Paul Taysom wrote: On Mon, Mar 4, 2013 at 9:42 AM, Alasdair G Kergon a...@redhat.com wrote: On Mon, Mar 04, 2013 at 08:45:48AM -0800, Paul

Re: [PATCH] md: dm-verity: Fix to avoid a deadlock in dm-bufio

2013-03-04 Thread Mikulas Patocka
On Mon, 4 Mar 2013, Paul Taysom wrote: > On Mon, Mar 4, 2013 at 9:42 AM, Alasdair G Kergon wrote: > > On Mon, Mar 04, 2013 at 08:45:48AM -0800, Paul Taysom wrote: > >> @@ -449,8 +468,14 @@ static void verity_prefetch_io(struct dm_verity *v, > >> struct dm_verity_io *io) > >>

Re: [PATCH] md: dm-verity: Fix to avoid a deadlock in dm-bufio

2013-03-04 Thread Paul Taysom
On Mon, Mar 4, 2013 at 9:42 AM, Alasdair G Kergon wrote: > On Mon, Mar 04, 2013 at 08:45:48AM -0800, Paul Taysom wrote: >> @@ -449,8 +468,14 @@ static void verity_prefetch_io(struct dm_verity *v, >> struct dm_verity_io *io) >> hash_block_end = v->hash_blocks - 1; >>

Re: [PATCH] md: dm-verity: Fix to avoid a deadlock in dm-bufio

2013-03-04 Thread Paul Taysom
On Mon, Mar 4, 2013 at 9:19 AM, Paul Menzel wrote: > > Am Montag, den 04.03.2013, 08:45 -0800 schrieb Paul Taysom: > > Changed the dm-verity prefetching to use a worker thread to avoid > > a deadlock in dm-bufio. > > Do you know of any bug reports about this? Searching for »dm-verity dead > lock«

Re: [PATCH] md: dm-verity: Fix to avoid a deadlock in dm-bufio

2013-03-04 Thread Alasdair G Kergon
On Mon, Mar 04, 2013 at 08:45:48AM -0800, Paul Taysom wrote: > @@ -449,8 +468,14 @@ static void verity_prefetch_io(struct dm_verity *v, > struct dm_verity_io *io) > hash_block_end = v->hash_blocks - 1; > } > no_prefetch_cluster: > -

Re: [PATCH] md: dm-verity: Fix to avoid a deadlock in dm-bufio

2013-03-04 Thread Paul Menzel
Am Montag, den 04.03.2013, 08:45 -0800 schrieb Paul Taysom: > Changed the dm-verity prefetching to use a worker thread to avoid > a deadlock in dm-bufio. Do you know of any bug reports about this? Searching for »dm-verity dead lock« I found [1], which seems to be the issue, right? If yes, please

[PATCH] md: dm-verity: Fix to avoid a deadlock in dm-bufio

2013-03-04 Thread Paul Taysom
Changed the dm-verity prefetching to use a worker thread to avoid a deadlock in dm-bufio. If generic_make_request is called recursively, it queues the I/O request on the current->bio_list without making the I/O request and returns. The routine making the recursive call cannot wait for the I/O to

[PATCH] md: dm-verity: Fix to avoid a deadlock in dm-bufio

2013-03-04 Thread Paul Taysom
Changed the dm-verity prefetching to use a worker thread to avoid a deadlock in dm-bufio. If generic_make_request is called recursively, it queues the I/O request on the current-bio_list without making the I/O request and returns. The routine making the recursive call cannot wait for the I/O to

Re: [PATCH] md: dm-verity: Fix to avoid a deadlock in dm-bufio

2013-03-04 Thread Paul Menzel
Am Montag, den 04.03.2013, 08:45 -0800 schrieb Paul Taysom: Changed the dm-verity prefetching to use a worker thread to avoid a deadlock in dm-bufio. Do you know of any bug reports about this? Searching for »dm-verity dead lock« I found [1], which seems to be the issue, right? If yes, please

Re: [PATCH] md: dm-verity: Fix to avoid a deadlock in dm-bufio

2013-03-04 Thread Alasdair G Kergon
On Mon, Mar 04, 2013 at 08:45:48AM -0800, Paul Taysom wrote: @@ -449,8 +468,14 @@ static void verity_prefetch_io(struct dm_verity *v, struct dm_verity_io *io) hash_block_end = v-hash_blocks - 1; } no_prefetch_cluster: -

Re: [PATCH] md: dm-verity: Fix to avoid a deadlock in dm-bufio

2013-03-04 Thread Paul Taysom
On Mon, Mar 4, 2013 at 9:19 AM, Paul Menzel pm.deb...@googlemail.com wrote: Am Montag, den 04.03.2013, 08:45 -0800 schrieb Paul Taysom: Changed the dm-verity prefetching to use a worker thread to avoid a deadlock in dm-bufio. Do you know of any bug reports about this? Searching for

Re: [PATCH] md: dm-verity: Fix to avoid a deadlock in dm-bufio

2013-03-04 Thread Paul Taysom
On Mon, Mar 4, 2013 at 9:42 AM, Alasdair G Kergon a...@redhat.com wrote: On Mon, Mar 04, 2013 at 08:45:48AM -0800, Paul Taysom wrote: @@ -449,8 +468,14 @@ static void verity_prefetch_io(struct dm_verity *v, struct dm_verity_io *io) hash_block_end = v-hash_blocks

Re: [PATCH] md: dm-verity: Fix to avoid a deadlock in dm-bufio

2013-03-04 Thread Mikulas Patocka
On Mon, 4 Mar 2013, Paul Taysom wrote: On Mon, Mar 4, 2013 at 9:42 AM, Alasdair G Kergon a...@redhat.com wrote: On Mon, Mar 04, 2013 at 08:45:48AM -0800, Paul Taysom wrote: @@ -449,8 +468,14 @@ static void verity_prefetch_io(struct dm_verity *v, struct dm_verity_io *io)