Re: [PATCH] mdio: mux: Correct mdio_mux_init error path issues

2017-05-11 Thread David Miller
From: Florian Fainelli Date: Thu, 11 May 2017 10:05:27 -0700 > On 05/10/2017 08:20 AM, Jon Mason wrote: >> There is a potential unnecessary refcount decriment on error path of >> put_device(>mii_bus->dev), as it is possible to avoid the >> of_mdio_find_bus() call if mux_bus

Re: [PATCH] mdio: mux: Correct mdio_mux_init error path issues

2017-05-11 Thread David Miller
From: Florian Fainelli Date: Thu, 11 May 2017 10:05:27 -0700 > On 05/10/2017 08:20 AM, Jon Mason wrote: >> There is a potential unnecessary refcount decriment on error path of >> put_device(>mii_bus->dev), as it is possible to avoid the >> of_mdio_find_bus() call if mux_bus is specified by the

Re: [PATCH] mdio: mux: Correct mdio_mux_init error path issues

2017-05-11 Thread Florian Fainelli
On 05/10/2017 08:20 AM, Jon Mason wrote: > There is a potential unnecessary refcount decriment on error path of > put_device(>mii_bus->dev), as it is possible to avoid the > of_mdio_find_bus() call if mux_bus is specified by the calling function. > > The same put_device() is not called in the

Re: [PATCH] mdio: mux: Correct mdio_mux_init error path issues

2017-05-11 Thread Florian Fainelli
On 05/10/2017 08:20 AM, Jon Mason wrote: > There is a potential unnecessary refcount decriment on error path of > put_device(>mii_bus->dev), as it is possible to avoid the > of_mdio_find_bus() call if mux_bus is specified by the calling function. > > The same put_device() is not called in the

[PATCH] mdio: mux: Correct mdio_mux_init error path issues

2017-05-10 Thread Jon Mason
There is a potential unnecessary refcount decriment on error path of put_device(>mii_bus->dev), as it is possible to avoid the of_mdio_find_bus() call if mux_bus is specified by the calling function. The same put_device() is not called in the error path if the devm_kzalloc of pb fails. This

[PATCH] mdio: mux: Correct mdio_mux_init error path issues

2017-05-10 Thread Jon Mason
There is a potential unnecessary refcount decriment on error path of put_device(>mii_bus->dev), as it is possible to avoid the of_mdio_find_bus() call if mux_bus is specified by the calling function. The same put_device() is not called in the error path if the devm_kzalloc of pb fails. This