Re: Re: [PATCH] media: coda: Fix runtime PM imbalance in coda_probe

> Hi Dinghao, > > thank you for the patch! The first part is fine, but I think the second > part is not necessary, see below: > > On Sat, May 23, 2020 at 06:03:32PM +0800, Dinghao Liu wrote: > > When coda_firmware_request() returns an error code, > > a pairing runtime PM usage counter decrement i

Re: [PATCH] media: coda: Fix runtime PM imbalance in coda_probe

Hi Dinghao, thank you for the patch! The first part is fine, but I think the second part is not necessary, see below: On Sat, May 23, 2020 at 06:03:32PM +0800, Dinghao Liu wrote: > When coda_firmware_request() returns an error code, > a pairing runtime PM usage counter decrement is needed > to ke

[PATCH] media: coda: Fix runtime PM imbalance in coda_probe

When coda_firmware_request() returns an error code, a pairing runtime PM usage counter decrement is needed to keep the counter balanced. Also, the caller expects coda_probe() to increase PM usage counter, there should be a refcount decrement in coda_remove() to keep the counter balanced. Signed-o