Re: [PATCH] media: gp8psk: initialize stats at power control logic

2020-11-30 Thread VDRU VDRU
Hi Mauro, After many attempts ret was always 0. Please let me know if further testing is needed. Best regards, Derek On Mon, Nov 30, 2020 at 9:09 AM Mauro Carvalho Chehab wrote: > > Hi Derek, > > Em Mon, 30 Nov 2020 08:04:31 -0800 > VDRU VDRU escreveu: > > > I have hardware that uses this driv

Re: [PATCH] media: gp8psk: initialize stats at power control logic

2020-11-30 Thread Mauro Carvalho Chehab
Hi Derek, Em Mon, 30 Nov 2020 08:04:31 -0800 VDRU VDRU escreveu: > I have hardware that uses this driver and can conduct a test if it > will help resolve any confusion/assumption. I'd also like to suggest > that making changes to drivers with no means of testing those changes > is bad. This has

Re: [PATCH] media: gp8psk: initialize stats at power control logic

2020-11-30 Thread VDRU VDRU
I have hardware that uses this driver and can conduct a test if it will help resolve any confusion/assumption. I'd also like to suggest that making changes to drivers with no means of testing those changes is bad. This has happened in the past and resulted in unnecessarily breaking drivers for thos

Re: [PATCH] media: gp8psk: initialize stats at power control logic

2020-11-30 Thread Mauro Carvalho Chehab
Em Fri, 27 Nov 2020 09:20:53 -0500 Willem de Bruijn escreveu: > On Fri, Nov 27, 2020 at 1:46 AM Mauro Carvalho Chehab > wrote: > > > > As reported on: > > > > https://lore.kernel.org/linux-media/20190627222020.45909-1-willemdebruijn.ker...@gmail.com/ > > > > if gp8psk_usb_in_op() return

Re: [PATCH] media: gp8psk: initialize stats at power control logic

2020-11-27 Thread Willem de Bruijn
On Fri, Nov 27, 2020 at 1:46 AM Mauro Carvalho Chehab wrote: > > As reported on: > > https://lore.kernel.org/linux-media/20190627222020.45909-1-willemdebruijn.ker...@gmail.com/ > > if gp8psk_usb_in_op() returns an error, the status var is not > initialized. Yet, this var is used later on,

[PATCH] media: gp8psk: initialize stats at power control logic

2020-11-26 Thread Mauro Carvalho Chehab
As reported on: https://lore.kernel.org/linux-media/20190627222020.45909-1-willemdebruijn.ker...@gmail.com/ if gp8psk_usb_in_op() returns an error, the status var is not initialized. Yet, this var is used later on, in order to identify: - if the device was already started;