Re: [PATCH] media: ov8856: Remove 3280x2464 mode

2020-12-08 Thread Tomasz Figa
On Fri, Nov 27, 2020 at 10:38 PM Robert Foss wrote: > > Thanks for digging into this everyone! > > Assuming Tomasz doesn't find any stretching, I think we can conclude > that this mode works, and should be kept. Thanks Dongchun for parsing > the datasheet and finding the Bayer mode issue for the

Re: [PATCH] media: ov8856: Remove 3280x2464 mode

2020-11-27 Thread Robert Foss
Thanks for digging into this everyone! Assuming Tomasz doesn't find any stretching, I think we can conclude that this mode works, and should be kept. Thanks Dongchun for parsing the datasheet and finding the Bayer mode issue for the two other recently added resolutions. On Fri, 27 Nov 2020 at

Re: [PATCH] media: ov8856: Remove 3280x2464 mode

2020-11-27 Thread Tomasz Figa
On Thu, Nov 26, 2020 at 7:00 PM Robert Foss wrote: > > On Wed, 25 Nov 2020 at 08:32, Tomasz Figa wrote: > > > > Hi Bingbu, > > > > On Wed, Nov 25, 2020 at 1:15 PM Bingbu Cao > > wrote: > > > > > > > > > > > > On 11/24/20 6:20 PM, Robert Foss wrote: > > > > On Tue, 24 Nov 2020 at 10:42, Bingbu

Re: [PATCH] media: ov8856: Remove 3280x2464 mode

2020-11-26 Thread Robert Foss
On Wed, 25 Nov 2020 at 08:32, Tomasz Figa wrote: > > Hi Bingbu, > > On Wed, Nov 25, 2020 at 1:15 PM Bingbu Cao wrote: > > > > > > > > On 11/24/20 6:20 PM, Robert Foss wrote: > > > On Tue, 24 Nov 2020 at 10:42, Bingbu Cao > > > wrote: > > >> > > >> Hi, Robert > > >> > > >> I remember that the

Re: [PATCH] media: ov8856: Remove 3280x2464 mode

2020-11-24 Thread Tomasz Figa
Hi Bingbu, On Wed, Nov 25, 2020 at 1:15 PM Bingbu Cao wrote: > > > > On 11/24/20 6:20 PM, Robert Foss wrote: > > On Tue, 24 Nov 2020 at 10:42, Bingbu Cao wrote: > >> > >> Hi, Robert > >> > >> I remember that the full size of ov8856 image sensor is 3296x2480 and we > >> can get the 3280x2464 >

Re: [PATCH] media: ov8856: Remove 3280x2464 mode

2020-11-24 Thread Bingbu Cao
On 11/24/20 6:20 PM, Robert Foss wrote: > On Tue, 24 Nov 2020 at 10:42, Bingbu Cao wrote: >> >> Hi, Robert >> >> I remember that the full size of ov8856 image sensor is 3296x2480 and we can >> get the 3280x2464 >> frames based on current settings. >> >> Do you have any issues with this mode?

Re: [PATCH] media: ov8856: Remove 3280x2464 mode

2020-11-24 Thread Tomasz Figa
Hi Robert, On Tue, Nov 17, 2020 at 12:52 AM Robert Foss wrote: > > Remove the 3280x2464 mode as it can't be reproduced and yields > an output resolution of 3264x2448 instead of the desired one. > > Furthermore the 3264x2448 resolution is the highest resolution > that the product brief lists. > >

Re: [PATCH] media: ov8856: Remove 3280x2464 mode

2020-11-24 Thread Robert Foss
> > OV8856 sensor array region consists of 3 main window settings. > The inner window is controlled by [H_win_off, V_win_off]. > From the old unusual 3280x2464 and 1640x1232 setting, > H_win_off(R3810-R3811) is 0, V_win_off(R3812-R3813) is 1. > > Considering that the register

Re: [PATCH] media: ov8856: Remove 3280x2464 mode

2020-11-24 Thread Robert Foss
On Tue, 24 Nov 2020 at 10:42, Bingbu Cao wrote: > > Hi, Robert > > I remember that the full size of ov8856 image sensor is 3296x2480 and we can > get the 3280x2464 > frames based on current settings. > > Do you have any issues with this mode? As far as I can tell using the 3280x2464 mode

Re: [PATCH] media: ov8856: Remove 3280x2464 mode

2020-11-24 Thread Robert Foss
On Tue, 24 Nov 2020 at 11:17, Dongchun Zhu (朱东春) wrote: > > Hi Robert, > > > > Just updated the identification method of first pixel on list. > > The bayer order for the new setting (either FULL or BINNING mode) shall be > BG/GR. > > This has been proved both theoretically and experimentally.

Re: [PATCH] media: ov8856: Remove 3280x2464 mode

2020-11-24 Thread Dongchun Zhu
Hi Sakari, On Tue, 2020-11-24 at 10:43 +0200, Sakari Ailus wrote: > Hi Dongchun, > > On Tue, Nov 24, 2020 at 03:40:51PM +0800, Dongchun Zhu wrote: > > > static const struct ov8856_mode supported_modes[] = { > > > - { > > > - .width = 3280, > > > - .height = 2464, > > > -

Re: [PATCH] media: ov8856: Remove 3280x2464 mode

2020-11-24 Thread Bingbu Cao
Hi, Robert I remember that the full size of ov8856 image sensor is 3296x2480 and we can get the 3280x2464 frames based on current settings. Do you have any issues with this mode? On 11/16/20 11:50 PM, Robert Foss wrote: > 0x3812, 0x00}, > 236 {0x3813, 0x01}, -- Best regards, Bingbu Cao

Re: [PATCH] media: ov8856: Remove 3280x2464 mode

2020-11-24 Thread Sakari Ailus
Hi Dongchun, On Tue, Nov 24, 2020 at 03:40:51PM +0800, Dongchun Zhu wrote: > > static const struct ov8856_mode supported_modes[] = { > > - { > > - .width = 3280, > > - .height = 2464, > > - .hts = 1928, > > - .vts_def = 2488, > > - .vts_min =

Re: [PATCH] media: ov8856: Remove 3280x2464 mode

2020-11-23 Thread Dongchun Zhu
Hi Robert, Thanks for the patch. On Mon, 2020-11-16 at 16:50 +0100, Robert Foss wrote: > Remove the 3280x2464 mode as it can't be reproduced and yields > an output resolution of 3264x2448 instead of the desired one. > > Furthermore the 3264x2448 resolution is the highest resolution > that the

[PATCH] media: ov8856: Remove 3280x2464 mode

2020-11-16 Thread Robert Foss
Remove the 3280x2464 mode as it can't be reproduced and yields an output resolution of 3264x2448 instead of the desired one. Furthermore the 3264x2448 resolution is the highest resolution that the product brief lists. Since 3280x2464 neither works correctly nor seems to be supported by the