Re: [PATCH] media: platform: exynos4-is: media-dev: Add missing of_node_put

2016-01-26 Thread Mauro Carvalho Chehab
Em Tue, 26 Jan 2016 08:12:15 +0100 Julia Lawall escreveu: > On Tue, 26 Jan 2016, Krzysztof Kozlowski wrote: > > > On 26.01.2016 15:24, Julia Lawall wrote: > > > > > > > > > On Tue, 26 Jan 2016, Krzysztof Kozlowski wrote: > > > > > >> On 26.01.2016 00:21, Amitoj Kaur Chawla wrote: > > >>

Re: [PATCH] media: platform: exynos4-is: media-dev: Add missing of_node_put

2016-01-25 Thread Julia Lawall
On Tue, 26 Jan 2016, Krzysztof Kozlowski wrote: > On 26.01.2016 15:24, Julia Lawall wrote: > > > > > > On Tue, 26 Jan 2016, Krzysztof Kozlowski wrote: > > > >> On 26.01.2016 00:21, Amitoj Kaur Chawla wrote: > >>> for_each_available_child_of_node and for_each_child_of_node perform an > >>> of_

Re: [PATCH] media: platform: exynos4-is: media-dev: Add missing of_node_put

2016-01-25 Thread Krzysztof Kozlowski
On 26.01.2016 15:24, Julia Lawall wrote: > > > On Tue, 26 Jan 2016, Krzysztof Kozlowski wrote: > >> On 26.01.2016 00:21, Amitoj Kaur Chawla wrote: >>> for_each_available_child_of_node and for_each_child_of_node perform an >>> of_node_get on each iteration, so to break out of the loop an of_node_

Re: [PATCH] media: platform: exynos4-is: media-dev: Add missing of_node_put

2016-01-25 Thread Julia Lawall
On Tue, 26 Jan 2016, Krzysztof Kozlowski wrote: > On 26.01.2016 00:21, Amitoj Kaur Chawla wrote: > > for_each_available_child_of_node and for_each_child_of_node perform an > > of_node_get on each iteration, so to break out of the loop an of_node_put is > > required. > > > > Found using Coccinel

Re: [PATCH] media: platform: exynos4-is: media-dev: Add missing of_node_put

2016-01-25 Thread Krzysztof Kozlowski
On 26.01.2016 00:21, Amitoj Kaur Chawla wrote: > for_each_available_child_of_node and for_each_child_of_node perform an > of_node_get on each iteration, so to break out of the loop an of_node_put is > required. > > Found using Coccinelle. The simplified version of the semantic patch > that is used

[PATCH] media: platform: exynos4-is: media-dev: Add missing of_node_put

2016-01-25 Thread Amitoj Kaur Chawla
for_each_available_child_of_node and for_each_child_of_node perform an of_node_get on each iteration, so to break out of the loop an of_node_put is required. Found using Coccinelle. The simplified version of the semantic patch that is used for this is as follows: // @@ local idexpression n; expr