Re: [PATCH] media: pxa_camera: disable and unprepare the clock source on error

Laurent Pinchart writes: > Hi Flavio, > > On Monday, 11 December 2017 23:05:46 EET Flavio Ceolin wrote: >> > On Wednesday, 6 December 2017 18:38:50 EET Flavio Ceolin wrote: >> >> pxa_camera_probe() was not calling pxa_camera_deactivate(), >> >> responsible to call clk_disable_unprepare(), on the

Re: [PATCH] media: pxa_camera: disable and unprepare the clock source on error

Hi Flavio, On Monday, 11 December 2017 23:05:46 EET Flavio Ceolin wrote: > > On Wednesday, 6 December 2017 18:38:50 EET Flavio Ceolin wrote: > >> pxa_camera_probe() was not calling pxa_camera_deactivate(), > >> responsible to call clk_disable_unprepare(), on the failure path. This > >> was leading

Re: [PATCH] media: pxa_camera: disable and unprepare the clock source on error

Hi Laurent, > Hi Flavio, > > Thank you for the patch. > > On Wednesday, 6 December 2017 18:38:50 EET Flavio Ceolin wrote: >> pxa_camera_probe() was not calling pxa_camera_deactivate(), >> responsible to call clk_disable_unprepare(), on the failure path. This >> was leading to unbalancing source cl

Re: [PATCH] media: pxa_camera: disable and unprepare the clock source on error

Hi Flavio, Thank you for the patch. On Wednesday, 6 December 2017 18:38:50 EET Flavio Ceolin wrote: > pxa_camera_probe() was not calling pxa_camera_deactivate(), > responsible to call clk_disable_unprepare(), on the failure path. This > was leading to unbalancing source clock. > > Found by Linux

[PATCH] media: pxa_camera: disable and unprepare the clock source on error

pxa_camera_probe() was not calling pxa_camera_deactivate(), responsible to call clk_disable_unprepare(), on the failure path. This was leading to unbalancing source clock. Found by Linux Driver Verification project (linuxtesting.org). Signed-off-by: Flavio Ceolin --- drivers/media/platform/pxa_