Re: [PATCH] media: rockchip: rkisp1: remove some dead code

Hi Dan, On 12/1/20 11:27 AM, Dan Carpenter wrote: > On Mon, Nov 30, 2020 at 11:20:05AM -0300, Helen Koike wrote: >> Hi Dan, >> >> Thank you for your patch. >> >> On 11/30/20 9:53 AM, Dan Carpenter wrote: >>> The debugfs_create_dir() function never returns NULLs. It's not supposed >>> to checked

Re: [PATCH] media: rockchip: rkisp1: remove some dead code

On Mon, Nov 30, 2020 at 11:20:05AM -0300, Helen Koike wrote: > Hi Dan, > > Thank you for your patch. > > On 11/30/20 9:53 AM, Dan Carpenter wrote: > > The debugfs_create_dir() function never returns NULLs. It's not supposed > > to checked for errors in the normal case and there is no need to

Re: [PATCH] media: rockchip: rkisp1: remove some dead code

Hi Dan, Thank you for your patch. On 11/30/20 9:53 AM, Dan Carpenter wrote: > The debugfs_create_dir() function never returns NULLs. It's not supposed > to checked for errors in the normal case and there is no need to check > in this function so let's just delete this dead code. > >

[PATCH] media: rockchip: rkisp1: remove some dead code

The debugfs_create_dir() function never returns NULLs. It's not supposed to checked for errors in the normal case and there is no need to check in this function so let's just delete this dead code. Signed-off-by: Dan Carpenter --- drivers/media/platform/rockchip/rkisp1/rkisp1-dev.c | 4 1