Re: [PATCH] media: stm32-dcmi: fix irq = 0 case

2019-06-03 Thread Hans Verkuil
On 6/3/19 3:03 PM, Fabien DESSENNE wrote: > Hi Hans > > > "platform_get_irq() = 0" shall be considered as an error. See these > discussions: > https://patchwork.kernel.org/patch/10006651/ > https://yarchive.net/comp/linux/zero.html Hmm, then many media drivers are wrong since most check for < 0

Re: [PATCH] media: stm32-dcmi: fix irq = 0 case

2019-06-03 Thread Fabien DESSENNE
Hi Hans "platform_get_irq() = 0" shall be considered as an error. See these discussions: https://patchwork.kernel.org/patch/10006651/ https://yarchive.net/comp/linux/zero.html BR Fabien On 03/06/2019 1:45 PM, Hans Verkuil wrote: > On 5/31/19 11:18 AM, Fabien Dessenne wrote: >> Manage the irq

Re: [PATCH] media: stm32-dcmi: fix irq = 0 case

2019-06-03 Thread Hans Verkuil
On 5/31/19 11:18 AM, Fabien Dessenne wrote: > Manage the irq = 0 case, where we shall return an error. > > Fixes: b5b5a27bee58 ("media: stm32-dcmi: return appropriate error codes > during probe") > Signed-off-by: Fabien Dessenne > --- > drivers/media/platform/stm32/stm32-dcmi.c | 2 +- > 1 file

Re: [PATCH] media: stm32-dcmi: fix irq = 0 case

2019-05-31 Thread Pavel Machek
On Fri 2019-05-31 11:18:15, Fabien Dessenne wrote: > Manage the irq = 0 case, where we shall return an error. > > Fixes: b5b5a27bee58 ("media: stm32-dcmi: return appropriate error codes > during probe") > Signed-off-by: Fabien Dessenne Acked-by: Pavel Machek Reported-by: Pavel Machek :-).

[PATCH] media: stm32-dcmi: fix irq = 0 case

2019-05-31 Thread Fabien Dessenne
Manage the irq = 0 case, where we shall return an error. Fixes: b5b5a27bee58 ("media: stm32-dcmi: return appropriate error codes during probe") Signed-off-by: Fabien Dessenne --- drivers/media/platform/stm32/stm32-dcmi.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/driver