Re: [PATCH] media: tc358743: initialize variable

2020-09-02 Thread Tom Rix
On 8/31/20 10:31 AM, Nick Desaulniers wrote: > On Sun, Aug 30, 2020 at 9:30 AM wrote: >> From: Tom Rix >> >> clang static analysis flags this error >> >> tc358743.c:1468:9: warning: Branch condition evaluates >> to a garbage value >> return handled ? IRQ_HANDLED : IRQ_NONE; >>

Re: [PATCH] media: tc358743: initialize variable

2020-08-31 Thread Tom Rix
On 8/31/20 10:31 AM, Nick Desaulniers wrote: > On Sun, Aug 30, 2020 at 9:30 AM wrote: >> From: Tom Rix >> >> clang static analysis flags this error >> >> tc358743.c:1468:9: warning: Branch condition evaluates >> to a garbage value >> return handled ? IRQ_HANDLED : IRQ_NONE; >>

Re: [PATCH] media: tc358743: initialize variable

2020-08-31 Thread Nick Desaulniers
On Sun, Aug 30, 2020 at 9:30 AM wrote: > > From: Tom Rix > > clang static analysis flags this error > > tc358743.c:1468:9: warning: Branch condition evaluates > to a garbage value > return handled ? IRQ_HANDLED : IRQ_NONE; >^~~ > handled should be initialized to

[PATCH] media: tc358743: initialize variable

2020-08-30 Thread trix
From: Tom Rix clang static analysis flags this error tc358743.c:1468:9: warning: Branch condition evaluates to a garbage value return handled ? IRQ_HANDLED : IRQ_NONE; ^~~ handled should be initialized to false. Fixes: d747b806abf4 ("[media] tc358743: add direct