kmemdup has implemented the function that kmalloc() + memcpy().
We prefer to kmemdup rather than code opened implementation.

Signed-off-by: zhong jiang <zhongji...@huawei.com>
---
 drivers/media/usb/dvb-usb-v2/gl861.c | 3 +--
 1 file changed, 1 insertion(+), 2 deletions(-)

diff --git a/drivers/media/usb/dvb-usb-v2/gl861.c 
b/drivers/media/usb/dvb-usb-v2/gl861.c
index 0559417..80fed44 100644
--- a/drivers/media/usb/dvb-usb-v2/gl861.c
+++ b/drivers/media/usb/dvb-usb-v2/gl861.c
@@ -200,11 +200,10 @@ struct friio_config {
        u8 *buf;
        int ret;
 
-       buf = kmalloc(wlen, GFP_KERNEL);
+       buf = kmemdup(wbuf, wlen, GFP_KERNEL);
        if (!buf)
                return -ENOMEM;
 
-       memcpy(buf, wbuf, wlen);
        ret = usb_control_msg(d->udev, usb_sndctrlpipe(d->udev, 0),
                                 GL861_REQ_I2C_RAW, GL861_WRITE,
                                 addr << (8 + 1), 0x0100, buf, wlen, 2000);
-- 
1.7.12.4

Reply via email to