[RESEND PATCH] media: uvc: Avoid cyclic entity chains due to malformed USB descriptors

2019-10-16 Thread Will Deacon
Way back in 2017, fuzzing the 4.14-rc2 USB stack with syzkaller kicked up the following WARNING from the UVC chain scanning code: | list_add double add: new=880069084010, prev=880069084010, | next=880067d22298. | [ cut here ] | WARNING: CPU: 1 PID: 1846

Re: [PATCH] media: uvc: Avoid cyclic entity chains due to malformed USB descriptors

2019-10-07 Thread Will Deacon
Hi Laurent, Sorry for the delay, I got tied up with other patches. On Wed, Oct 02, 2019 at 09:56:04PM +0300, Laurent Pinchart wrote: > On Wed, Oct 02, 2019 at 02:19:29PM +0100, Will Deacon wrote: > > > uvc_scan_chain_forward() is then called (from uvc_scan_chain()), and > > > iterates over all

Re: [PATCH] media: uvc: Avoid cyclic entity chains due to malformed USB descriptors

2019-10-02 Thread Laurent Pinchart
Hi Will, On Wed, Oct 02, 2019 at 02:19:29PM +0100, Will Deacon wrote: > On Wed, Oct 02, 2019 at 04:09:13PM +0300, Laurent Pinchart wrote: > > Thank you for the patch. > > And thank you for the quick response. > > > On Wed, Oct 02, 2019 at 12:27:53PM +0100, Will Deacon wrote: > > > I don't have

Re: [PATCH] media: uvc: Avoid cyclic entity chains due to malformed USB descriptors

2019-10-02 Thread Will Deacon
Hi Laurent, On Wed, Oct 02, 2019 at 04:09:13PM +0300, Laurent Pinchart wrote: > Thank you for the patch. And thank you for the quick response. > On Wed, Oct 02, 2019 at 12:27:53PM +0100, Will Deacon wrote: > > I don't have a way to reproduce the original issue, so this change is > > based

Re: [PATCH] media: uvc: Avoid cyclic entity chains due to malformed USB descriptors

2019-10-02 Thread Laurent Pinchart
Hi Will, Thank you for the patch. On Wed, Oct 02, 2019 at 12:27:53PM +0100, Will Deacon wrote: > Way back in 2017, fuzzing the 4.14-rc2 USB stack with syzkaller kicked > up the following WARNING from the UVC chain scanning code: > > | list_add double add: new=880069084010,

[PATCH] media: uvc: Avoid cyclic entity chains due to malformed USB descriptors

2019-10-02 Thread Will Deacon
Way back in 2017, fuzzing the 4.14-rc2 USB stack with syzkaller kicked up the following WARNING from the UVC chain scanning code: | list_add double add: new=880069084010, prev=880069084010, | next=880067d22298. | [ cut here ] | WARNING: CPU: 1 PID: 1846