Re: [PATCH] media: zoran: move to dma-mapping interface

2018-05-07 Thread Arnd Bergmann
On Mon, May 7, 2018 at 5:05 AM, Hans Verkuil wrote: > On 25/04/18 19:22, Mauro Carvalho Chehab wrote: >> Em Wed, 25 Apr 2018 17:58:25 +0200 >> Arnd Bergmann escreveu: >> >>> On Wed, Apr 25, 2018 at 5:26 PM, Christoph Hellwig >>> wrote:

Re: [PATCH] media: zoran: move to dma-mapping interface

2018-05-07 Thread Arnd Bergmann
On Mon, May 7, 2018 at 5:05 AM, Hans Verkuil wrote: > On 25/04/18 19:22, Mauro Carvalho Chehab wrote: >> Em Wed, 25 Apr 2018 17:58:25 +0200 >> Arnd Bergmann escreveu: >> >>> On Wed, Apr 25, 2018 at 5:26 PM, Christoph Hellwig >>> wrote: On Wed, Apr 25, 2018 at 01:15:18PM +0200, Arnd

Re: [PATCH] media: zoran: move to dma-mapping interface

2018-05-07 Thread Hans Verkuil
On 25/04/18 19:22, Mauro Carvalho Chehab wrote: > Em Wed, 25 Apr 2018 17:58:25 +0200 > Arnd Bergmann escreveu: > >> On Wed, Apr 25, 2018 at 5:26 PM, Christoph Hellwig >> wrote: >>> On Wed, Apr 25, 2018 at 01:15:18PM +0200, Arnd Bergmann wrote: That

Re: [PATCH] media: zoran: move to dma-mapping interface

2018-05-07 Thread Hans Verkuil
On 25/04/18 19:22, Mauro Carvalho Chehab wrote: > Em Wed, 25 Apr 2018 17:58:25 +0200 > Arnd Bergmann escreveu: > >> On Wed, Apr 25, 2018 at 5:26 PM, Christoph Hellwig >> wrote: >>> On Wed, Apr 25, 2018 at 01:15:18PM +0200, Arnd Bergmann wrote: That thought had occurred to me as well. I

Re: [PATCH] media: zoran: move to dma-mapping interface

2018-04-26 Thread kbuild test robot
Hi Arnd, I love your patch! Perhaps something to improve: [auto build test WARNING on linuxtv-media/master] [also build test WARNING on v4.17-rc2 next-20180426] [if your patch is applied to the wrong git tree, please drop us a note to help improve the system] url:

Re: [PATCH] media: zoran: move to dma-mapping interface

2018-04-26 Thread kbuild test robot
Hi Arnd, I love your patch! Perhaps something to improve: [auto build test WARNING on linuxtv-media/master] [also build test WARNING on v4.17-rc2 next-20180426] [if your patch is applied to the wrong git tree, please drop us a note to help improve the system] url:

Re: [Mjpeg-users] [PATCH] media: zoran: move to dma-mapping interface

2018-04-25 Thread Bernhard Praschinger
Hallo Christoph Hellwig wrote: On Wed, Apr 25, 2018 at 09:08:13AM +0200, Arnd Bergmann wrote: That probably also means it can use dma_mmap_coherent instead of the handcrafted remap_pfn_range loop and the PageReserved abuse. I'd rather not touch that code. How about adding a comment about the

Re: [Mjpeg-users] [PATCH] media: zoran: move to dma-mapping interface

2018-04-25 Thread Bernhard Praschinger
Hallo Christoph Hellwig wrote: On Wed, Apr 25, 2018 at 09:08:13AM +0200, Arnd Bergmann wrote: That probably also means it can use dma_mmap_coherent instead of the handcrafted remap_pfn_range loop and the PageReserved abuse. I'd rather not touch that code. How about adding a comment about the

Re: [PATCH] media: zoran: move to dma-mapping interface

2018-04-25 Thread Trent Piepho
On Wed, 2018-04-25 at 14:22 -0300, Mauro Carvalho Chehab wrote: > Em Wed, 25 Apr 2018 17:58:25 +0200 > Arnd Bergmann escreveu: > > > On Wed, Apr 25, 2018 at 5:26 PM, Christoph Hellwig > rg> wrote: > > > On Wed, Apr 25, 2018 at 01:15:18PM +0200, Arnd Bergmann

Re: [PATCH] media: zoran: move to dma-mapping interface

2018-04-25 Thread Trent Piepho
On Wed, 2018-04-25 at 14:22 -0300, Mauro Carvalho Chehab wrote: > Em Wed, 25 Apr 2018 17:58:25 +0200 > Arnd Bergmann escreveu: > > > On Wed, Apr 25, 2018 at 5:26 PM, Christoph Hellwig > rg> wrote: > > > On Wed, Apr 25, 2018 at 01:15:18PM +0200, Arnd Bergmann wrote: > > > > That thought had

Re: [PATCH] media: zoran: move to dma-mapping interface

2018-04-25 Thread Mauro Carvalho Chehab
Em Wed, 25 Apr 2018 17:58:25 +0200 Arnd Bergmann escreveu: > On Wed, Apr 25, 2018 at 5:26 PM, Christoph Hellwig wrote: > > On Wed, Apr 25, 2018 at 01:15:18PM +0200, Arnd Bergmann wrote: > >> That thought had occurred to me as well. I removed the oldest ISDN

Re: [PATCH] media: zoran: move to dma-mapping interface

2018-04-25 Thread Mauro Carvalho Chehab
Em Wed, 25 Apr 2018 17:58:25 +0200 Arnd Bergmann escreveu: > On Wed, Apr 25, 2018 at 5:26 PM, Christoph Hellwig wrote: > > On Wed, Apr 25, 2018 at 01:15:18PM +0200, Arnd Bergmann wrote: > >> That thought had occurred to me as well. I removed the oldest ISDN > >> drivers already some years

Re: [PATCH] media: zoran: move to dma-mapping interface

2018-04-25 Thread Arnd Bergmann
On Wed, Apr 25, 2018 at 5:26 PM, Christoph Hellwig wrote: > On Wed, Apr 25, 2018 at 01:15:18PM +0200, Arnd Bergmann wrote: >> That thought had occurred to me as well. I removed the oldest ISDN >> drivers already some years ago, and the OSS sound drivers >> got removed as well,

Re: [PATCH] media: zoran: move to dma-mapping interface

2018-04-25 Thread Arnd Bergmann
On Wed, Apr 25, 2018 at 5:26 PM, Christoph Hellwig wrote: > On Wed, Apr 25, 2018 at 01:15:18PM +0200, Arnd Bergmann wrote: >> That thought had occurred to me as well. I removed the oldest ISDN >> drivers already some years ago, and the OSS sound drivers >> got removed as well, and comedi got

Re: [PATCH] media: zoran: move to dma-mapping interface

2018-04-25 Thread Christoph Hellwig
On Wed, Apr 25, 2018 at 01:15:18PM +0200, Arnd Bergmann wrote: > That thought had occurred to me as well. I removed the oldest ISDN > drivers already some years ago, and the OSS sound drivers > got removed as well, and comedi got converted to the dma-mapping > interfaces, so there isn't much left

Re: [PATCH] media: zoran: move to dma-mapping interface

2018-04-25 Thread Christoph Hellwig
On Wed, Apr 25, 2018 at 01:15:18PM +0200, Arnd Bergmann wrote: > That thought had occurred to me as well. I removed the oldest ISDN > drivers already some years ago, and the OSS sound drivers > got removed as well, and comedi got converted to the dma-mapping > interfaces, so there isn't much left

Re: [PATCH] media: zoran: move to dma-mapping interface

2018-04-25 Thread Arnd Bergmann
On Wed, Apr 25, 2018 at 9:21 AM, Christoph Hellwig wrote: > On Wed, Apr 25, 2018 at 09:08:13AM +0200, Arnd Bergmann wrote: >> > That probably also means it can use dma_mmap_coherent instead of the >> > handcrafted remap_pfn_range loop and the PageReserved abuse. >> >> I'd

Re: [PATCH] media: zoran: move to dma-mapping interface

2018-04-25 Thread Arnd Bergmann
On Wed, Apr 25, 2018 at 9:21 AM, Christoph Hellwig wrote: > On Wed, Apr 25, 2018 at 09:08:13AM +0200, Arnd Bergmann wrote: >> > That probably also means it can use dma_mmap_coherent instead of the >> > handcrafted remap_pfn_range loop and the PageReserved abuse. >> >> I'd rather not touch that

Re: [PATCH] media: zoran: move to dma-mapping interface

2018-04-25 Thread Christoph Hellwig
On Wed, Apr 25, 2018 at 09:08:13AM +0200, Arnd Bergmann wrote: > > That probably also means it can use dma_mmap_coherent instead of the > > handcrafted remap_pfn_range loop and the PageReserved abuse. > > I'd rather not touch that code. How about adding a comment about > the fact that it should

Re: [PATCH] media: zoran: move to dma-mapping interface

2018-04-25 Thread Christoph Hellwig
On Wed, Apr 25, 2018 at 09:08:13AM +0200, Arnd Bergmann wrote: > > That probably also means it can use dma_mmap_coherent instead of the > > handcrafted remap_pfn_range loop and the PageReserved abuse. > > I'd rather not touch that code. How about adding a comment about > the fact that it should

Re: [PATCH] media: zoran: move to dma-mapping interface

2018-04-25 Thread Arnd Bergmann
On Wed, Apr 25, 2018 at 8:15 AM, Christoph Hellwig wrote: > On Tue, Apr 24, 2018 at 10:40:45PM +0200, Arnd Bergmann wrote: >> @@ -221,6 +222,7 @@ struct zoran_fh { >> >> struct zoran_overlay_settings overlay_settings; >> u32 *overlay_mask; /*

Re: [PATCH] media: zoran: move to dma-mapping interface

2018-04-25 Thread Arnd Bergmann
On Wed, Apr 25, 2018 at 8:15 AM, Christoph Hellwig wrote: > On Tue, Apr 24, 2018 at 10:40:45PM +0200, Arnd Bergmann wrote: >> @@ -221,6 +222,7 @@ struct zoran_fh { >> >> struct zoran_overlay_settings overlay_settings; >> u32 *overlay_mask; /* overlay mask */ >> +

Re: [PATCH] media: zoran: move to dma-mapping interface

2018-04-25 Thread Christoph Hellwig
On Tue, Apr 24, 2018 at 10:40:45PM +0200, Arnd Bergmann wrote: > No drivers should use virt_to_bus() any more. This converts > one of the few remaining ones to the DMA mapping interface. > > Signed-off-by: Arnd Bergmann > --- > drivers/media/pci/zoran/Kconfig| 2 +- >

Re: [PATCH] media: zoran: move to dma-mapping interface

2018-04-25 Thread Christoph Hellwig
On Tue, Apr 24, 2018 at 10:40:45PM +0200, Arnd Bergmann wrote: > No drivers should use virt_to_bus() any more. This converts > one of the few remaining ones to the DMA mapping interface. > > Signed-off-by: Arnd Bergmann > --- > drivers/media/pci/zoran/Kconfig| 2 +- >

[PATCH] media: zoran: move to dma-mapping interface

2018-04-24 Thread Arnd Bergmann
No drivers should use virt_to_bus() any more. This converts one of the few remaining ones to the DMA mapping interface. Signed-off-by: Arnd Bergmann --- drivers/media/pci/zoran/Kconfig| 2 +- drivers/media/pci/zoran/zoran.h| 10 +--

[PATCH] media: zoran: move to dma-mapping interface

2018-04-24 Thread Arnd Bergmann
No drivers should use virt_to_bus() any more. This converts one of the few remaining ones to the DMA mapping interface. Signed-off-by: Arnd Bergmann --- drivers/media/pci/zoran/Kconfig| 2 +- drivers/media/pci/zoran/zoran.h| 10 +-- drivers/media/pci/zoran/zoran_card.c |