Re: [PATCH] memblock: fix section mismatch warning again

2021-03-16 Thread Nick Desaulniers
On Tue, Mar 16, 2021 at 10:13 AM Mike Rapoport wrote: > > From: Mike Rapoport > > Commit 34dc2efb39a2 ("memblock: fix section mismatch warning") marked > memblock_bottom_up() and memblock_set_bottom_up() as __init, but they could > be referenced from non-init functions like memblock_find_in_range

Re: [PATCH] memblock: fix section mismatch warning again

2021-03-16 Thread David Hildenbrand
On 16.03.21 18:13, Mike Rapoport wrote: From: Mike Rapoport Commit 34dc2efb39a2 ("memblock: fix section mismatch warning") marked memblock_bottom_up() and memblock_set_bottom_up() as __init, but they could be referenced from non-init functions like memblock_find_in_range_node() on architectures

[PATCH] memblock: fix section mismatch warning again

2021-03-16 Thread Mike Rapoport
From: Mike Rapoport Commit 34dc2efb39a2 ("memblock: fix section mismatch warning") marked memblock_bottom_up() and memblock_set_bottom_up() as __init, but they could be referenced from non-init functions like memblock_find_in_range_node() on architectures that enable CONFIG_ARCH_KEEP_MEMBLOCK. F

Re: [PATCH] memblock: fix section mismatch warning

2021-02-25 Thread Mike Rapoport
On Thu, Feb 25, 2021 at 02:38:00PM +0100, Arnd Bergmann wrote: > From: Arnd Bergmann > > The inlining logic in clang-13 is rewritten to often not inline > some functions that were inlined by all earlier compilers. > > In case of the memblock interfaces, this exposed a harmless bug > of a missing

Re: [PATCH] memblock: fix section mismatch warning

2021-02-25 Thread Arnd Bergmann
On Thu, Feb 25, 2021 at 4:08 PM Mike Rapoport wrote: > On Thu, Feb 25, 2021 at 03:06:27PM +0100, Arnd Bergmann wrote: > > On Thu, Feb 25, 2021 at 2:47 PM David Hildenbrand wrote: > > > > > > (I don't see why to not inline that function, but I am obviously not a > > > compiler person :) ) > > > >

Re: [PATCH] memblock: fix section mismatch warning

2021-02-25 Thread Mike Rapoport
On Thu, Feb 25, 2021 at 03:06:27PM +0100, Arnd Bergmann wrote: > On Thu, Feb 25, 2021 at 2:47 PM David Hildenbrand wrote: > > > > On 25.02.21 14:38, Arnd Bergmann wrote: > > > From: Arnd Bergmann > > > > > > The inlining logic in clang-13 is rewritten to often not inline > > > some functions that

Re: [PATCH] memblock: fix section mismatch warning

2021-02-25 Thread David Hildenbrand
On 25.02.21 15:06, Arnd Bergmann wrote: On Thu, Feb 25, 2021 at 2:47 PM David Hildenbrand wrote: On 25.02.21 14:38, Arnd Bergmann wrote: From: Arnd Bergmann The inlining logic in clang-13 is rewritten to often not inline some functions that were inlined by all earlier compilers. In case of

Re: [PATCH] memblock: fix section mismatch warning

2021-02-25 Thread Arnd Bergmann
On Thu, Feb 25, 2021 at 2:47 PM David Hildenbrand wrote: > > On 25.02.21 14:38, Arnd Bergmann wrote: > > From: Arnd Bergmann > > > > The inlining logic in clang-13 is rewritten to often not inline > > some functions that were inlined by all earlier compilers. > > > > In case of the memblock inter

Re: [PATCH] memblock: fix section mismatch warning

2021-02-25 Thread David Hildenbrand
On 25.02.21 14:38, Arnd Bergmann wrote: From: Arnd Bergmann The inlining logic in clang-13 is rewritten to often not inline some functions that were inlined by all earlier compilers. In case of the memblock interfaces, this exposed a harmless bug of a missing __init annotation: WARNING: modpo

[PATCH] memblock: fix section mismatch warning

2021-02-25 Thread Arnd Bergmann
From: Arnd Bergmann The inlining logic in clang-13 is rewritten to often not inline some functions that were inlined by all earlier compilers. In case of the memblock interfaces, this exposed a harmless bug of a missing __init annotation: WARNING: modpost: vmlinux.o(.text+0x507c0a): Section mis