Re: [PATCH] memcg: do not call reclaim if !__GFP_WAIT

2015-06-01 Thread Vlastimil Babka
On 05/29/2015 08:55 AM, Michal Hocko wrote: > On Thu 28-05-15 12:59:34, Andrew Morton wrote: >> On Thu, 28 May 2015 20:26:06 +0300 Vladimir Davydov >> wrote: >> >> > When trimming memcg consumption excess (see memory.high), we call >> > try_to_free_mem_cgroup_pages without checking if we are all

Re: [PATCH] memcg: do not call reclaim if !__GFP_WAIT

2015-05-28 Thread Michal Hocko
On Thu 28-05-15 12:59:34, Andrew Morton wrote: > On Thu, 28 May 2015 20:26:06 +0300 Vladimir Davydov > wrote: > > > When trimming memcg consumption excess (see memory.high), we call > > try_to_free_mem_cgroup_pages without checking if we are allowed to sleep > > in the current context, which can

Re: [PATCH] memcg: do not call reclaim if !__GFP_WAIT

2015-05-28 Thread Andrew Morton
On Thu, 28 May 2015 20:26:06 +0300 Vladimir Davydov wrote: > When trimming memcg consumption excess (see memory.high), we call > try_to_free_mem_cgroup_pages without checking if we are allowed to sleep > in the current context, which can result in a deadlock. Fix this. Why does it deadlock? tr

Re: [PATCH] memcg: do not call reclaim if !__GFP_WAIT

2015-05-28 Thread Michal Hocko
On Thu 28-05-15 20:26:06, Vladimir Davydov wrote: > When trimming memcg consumption excess (see memory.high), we call > try_to_free_mem_cgroup_pages without checking if we are allowed to sleep > in the current context, which can result in a deadlock. Fix this. > Fixes: 241994ed8649 ("mm: memcontr

[PATCH] memcg: do not call reclaim if !__GFP_WAIT

2015-05-28 Thread Vladimir Davydov
When trimming memcg consumption excess (see memory.high), we call try_to_free_mem_cgroup_pages without checking if we are allowed to sleep in the current context, which can result in a deadlock. Fix this. Signed-off-by: Vladimir Davydov Cc: Johannes Weiner Cc: Michal Hocko --- mm/memcontrol.c