Re: [PATCH] memcg: fix hotplugged memory zone oops

2012-11-03 Thread Michal Hocko
On Fri 02-11-12 16:37:37, Hugh Dickins wrote: > On Fri, 2 Nov 2012, Michal Hocko wrote: > > On Fri 02-11-12 11:21:59, Michal Hocko wrote: > > > On Thu 01-11-12 18:28:02, Hugh Dickins wrote: > > [...] > > > > And I forgot to mention that the following hunk will clash with > > "memcg: Simplify mem_c

Re: [PATCH] memcg: fix hotplugged memory zone oops

2012-11-02 Thread Hugh Dickins
On Fri, 2 Nov 2012, Michal Hocko wrote: > On Fri 02-11-12 11:21:59, Michal Hocko wrote: > > On Thu 01-11-12 18:28:02, Hugh Dickins wrote: > [...] > > And I forgot to mention that the following hunk will clash with > "memcg: Simplify mem_cgroup_force_empty_list error handling" which is in > linux-n

Re: [PATCH] memcg: fix hotplugged memory zone oops

2012-11-02 Thread Hugh Dickins
On Fri, 2 Nov 2012, Michal Hocko wrote: > > OK, it adds "an overhead" also when there is no hotadd going on but this > is just one additional mem access&cmp&je so it shouldn't be noticable > (lruvec->zone is used most of the time later so it not a pointless > load). I think so too. > It is also

Re: [PATCH] memcg: fix hotplugged memory zone oops

2012-11-02 Thread Michal Hocko
On Fri 02-11-12 11:21:59, Michal Hocko wrote: > On Thu 01-11-12 18:28:02, Hugh Dickins wrote: [...] And I forgot to mention that the following hunk will clash with "memcg: Simplify mem_cgroup_force_empty_list error handling" which is in linux-next already (via Tejun's tree). Would it be easier to

Re: [PATCH] memcg: fix hotplugged memory zone oops

2012-11-02 Thread Michal Hocko
On Thu 01-11-12 18:28:02, Hugh Dickins wrote: > When MEMCG is configured on (even when it's disabled by boot option), > when adding or removing a page to/from its lru list, the zone pointer > used for stats updates is nowadays taken from the struct lruvec. > (On many configurations, calculating zon

[PATCH] memcg: fix hotplugged memory zone oops

2012-11-01 Thread Hugh Dickins
When MEMCG is configured on (even when it's disabled by boot option), when adding or removing a page to/from its lru list, the zone pointer used for stats updates is nowadays taken from the struct lruvec. (On many configurations, calculating zone from page is slower.) But we have no code to update