Re: [PATCH] memcg: put soft limit reclaim out of way if the excess tree is empty

2016-08-01 Thread Vladimir Davydov
On Mon, Aug 01, 2016 at 04:12:28PM +0200, Michal Hocko wrote: ... > From: Michal Hocko > Date: Mon, 1 Aug 2016 10:42:06 +0200 > Subject: [PATCH] memcg: put soft limit reclaim out of way if the excess tree > is empty > > We've had a report about soft lockups caused by lock

Re: [PATCH] memcg: put soft limit reclaim out of way if the excess tree is empty

2016-08-01 Thread Michal Hocko
On Mon 01-08-16 13:17:17, Johannes Weiner wrote: > On Mon, Aug 01, 2016 at 05:24:54PM +0200, Michal Hocko wrote: > > @@ -2564,7 +2559,13 @@ unsigned long > > mem_cgroup_soft_limit_reclaim(pg_data_t *pgdat, int order, > > return 0; > > > > mctz = soft_limit_tree_node(pgdat->node_i

Re: [PATCH] memcg: put soft limit reclaim out of way if the excess tree is empty

2016-08-01 Thread Johannes Weiner
On Mon, Aug 01, 2016 at 05:24:54PM +0200, Michal Hocko wrote: > @@ -2564,7 +2559,13 @@ unsigned long mem_cgroup_soft_limit_reclaim(pg_data_t > *pgdat, int order, > return 0; > > mctz = soft_limit_tree_node(pgdat->node_id); > - if (soft_limit_tree_empty(mctz)) > + > +

Re: [PATCH] memcg: put soft limit reclaim out of way if the excess tree is empty

2016-08-01 Thread Michal Hocko
On Mon 01-08-16 11:03:43, Johannes Weiner wrote: > On Mon, Aug 01, 2016 at 04:12:28PM +0200, Michal Hocko wrote: [...] > > diff --git a/mm/memcontrol.c b/mm/memcontrol.c > > index c265212bec8c..c0b57b6a194e 100644 > > --- a/mm/memcontrol.c > > +++ b/mm/memcontrol.c > > @@ -2543,6 +2543,11 @@ static

Re: [PATCH] memcg: put soft limit reclaim out of way if the excess tree is empty

2016-08-01 Thread Johannes Weiner
On Mon, Aug 01, 2016 at 04:12:28PM +0200, Michal Hocko wrote: > From: Michal Hocko > Date: Mon, 1 Aug 2016 10:42:06 +0200 > Subject: [PATCH] memcg: put soft limit reclaim out of way if the excess tree > is empty > > We've had a report about soft lockups caused by lock

Re: [PATCH] memcg: put soft limit reclaim out of way if the excess tree is empty

2016-08-01 Thread Vladimir Davydov
On Mon, Aug 01, 2016 at 12:00:21PM +0200, Michal Hocko wrote: ... > diff --git a/mm/memcontrol.c b/mm/memcontrol.c > index c265212bec8c..eb7e39c2d948 100644 > --- a/mm/memcontrol.c > +++ b/mm/memcontrol.c > @@ -2543,6 +2543,11 @@ static int mem_cgroup_resize_memsw_limit(struct > mem_cgroup *memcg,

Re: [PATCH] memcg: put soft limit reclaim out of way if the excess tree is empty

2016-08-01 Thread Michal Hocko
tch. --- >From 9076cc87cbc49d8c16cee4120c7f5e518511b953 Mon Sep 17 00:00:00 2001 From: Michal Hocko Date: Mon, 1 Aug 2016 10:42:06 +0200 Subject: [PATCH] memcg: put soft limit reclaim out of way if the excess tree is empty We've had a report about soft lockups caused by lock bouncing

[PATCH] memcg: put soft limit reclaim out of way if the excess tree is empty

2016-08-01 Thread Michal Hocko
From: Michal Hocko We've had a report about soft lockups caused by lock bouncing in the soft reclaim path: [331404.849734] BUG: soft lockup - CPU#0 stuck for 22s! [kav4proxy-kavic:3128] [331404.849920] RIP: 0010:[] [] _raw_spin_lock+0x18/0x20 [331404.849997] Call Trace: [331404.850010] [] mem