Re: [PATCH] mfd: Only unregister platform devices allocated by the mfd core

2012-11-09 Thread Mark Brown
On Thu, Nov 08, 2012 at 05:23:00PM +, Charles Keepax wrote: > +static struct device_type mfd_dev_type = { > + .name = "MFD_DEVICE", > +}; This seems non-idiomatic, other device types all have lower case names (which are much more common in Unixish systems in general). signature.asc

Re: [PATCH] mfd: Only unregister platform devices allocated by the mfd core

2012-11-09 Thread Mark Brown
On Thu, Nov 08, 2012 at 05:23:00PM +, Charles Keepax wrote: +static struct device_type mfd_dev_type = { + .name = MFD_DEVICE, +}; This seems non-idiomatic, other device types all have lower case names (which are much more common in Unixish systems in general). signature.asc

[PATCH] mfd: Only unregister platform devices allocated by the mfd core

2012-11-08 Thread Charles Keepax
mfd_remove_devices would iterate over all devices sharing a parent with an mfd device regardless of whether they were allocated by the mfd core or not. This especially caused problems when the device structure was not contained within a platform_device, because to_platform_device is used on each

[PATCH] mfd: Only unregister platform devices allocated by the mfd core

2012-11-08 Thread Charles Keepax
mfd_remove_devices would iterate over all devices sharing a parent with an mfd device regardless of whether they were allocated by the mfd core or not. This especially caused problems when the device structure was not contained within a platform_device, because to_platform_device is used on each