Re: [PATCH] mfd: arizona: Don't use regmap_read_poll_timeout

2018-06-04 Thread Charles Keepax
On Mon, Jun 04, 2018 at 11:27:19AM +0100, Charles Keepax wrote: > On Mon, Jun 04, 2018 at 12:40:37PM +0300, Andy Shevchenko wrote: > > On Mon, Jun 4, 2018 at 8:44 AM, Lee Jones wrote: > > > On Fri, 11 May 2018, Charles Keepax wrote: > > > > >> + while (true) { > > >> + ret = regma

Re: [PATCH] mfd: arizona: Don't use regmap_read_poll_timeout

2018-06-04 Thread Charles Keepax
On Mon, Jun 04, 2018 at 12:40:37PM +0300, Andy Shevchenko wrote: > On Mon, Jun 4, 2018 at 8:44 AM, Lee Jones wrote: > > On Fri, 11 May 2018, Charles Keepax wrote: > > >> + while (true) { > >> + ret = regmap_read(arizona->regmap, reg, &val); > >> > >> + if ((val & mask)

Re: [PATCH] mfd: arizona: Don't use regmap_read_poll_timeout

2018-06-04 Thread Andy Shevchenko
On Mon, Jun 4, 2018 at 8:44 AM, Lee Jones wrote: > On Fri, 11 May 2018, Charles Keepax wrote: >> + while (true) { >> + ret = regmap_read(arizona->regmap, reg, &val); >> >> + if ((val & mask) == target) >> + return 0; >> + >> + if (ktime_

Re: [PATCH] mfd: arizona: Don't use regmap_read_poll_timeout

2018-06-03 Thread Lee Jones
On Fri, 11 May 2018, Charles Keepax wrote: > Some Arizona CODECs have a small timing window where they will > NAK an I2C transaction if it happens before the boot done bit is > set. This can cause the read of the register containing the boot > done bit to fail until it is set. Since regmap_read_po

[PATCH] mfd: arizona: Don't use regmap_read_poll_timeout

2018-05-11 Thread Charles Keepax
Some Arizona CODECs have a small timing window where they will NAK an I2C transaction if it happens before the boot done bit is set. This can cause the read of the register containing the boot done bit to fail until it is set. Since regmap_read_poll_timeout will abort polling if a read fails it can