Re: [PATCH] mfd: axp20x: Add a cell for the power button part of the,axp288 PMICs

2015-10-14 Thread Lee Jones
On Wed, 14 Oct 2015, Borun Fu wrote: > So the patch will be refined to remove the comment as follows. Any > else comments? Please don't top post. If you have a comment about something that was said, please make your comment directly _after_ it (a.k.a inline). > @@ -572,6 +587,11 @@ static stru

Re: [PATCH] mfd: axp20x: Add a cell for the power button part of the,axp288 PMICs

2015-10-14 Thread Borun Fu
So the patch will be refined to remove the comment as follows. Any else comments? @@ -572,6 +587,11 @@ static struct mfd_cell axp288_cells[] = { .resources = axp288_fuel_gauge_resources, }, { + .name = "axp20x-pek", + .num_resources = AR

Re: [PATCH] mfd: axp20x: Add a cell for the power button part of the,axp288 PMICs

2015-10-14 Thread Lee Jones
On Tue, 13 Oct 2015, Yang, Fei wrote: > >> static struct resource axp288_fuel_gauge_resources[] = { > >>{ > >>.start = AXP288_IRQ_QWBTU, > >> @@ -572,6 +587,11 @@ static struct mfd_cell axp288_cells[] = { > >>.resources = axp288_fuel_gauge_resources, > >>}, > >>

RE: [PATCH] mfd: axp20x: Add a cell for the power button part of the,axp288 PMICs

2015-10-13 Thread Yang, Fei
>> static struct resource axp288_fuel_gauge_resources[] = { >> { >> .start = AXP288_IRQ_QWBTU, >> @@ -572,6 +587,11 @@ static struct mfd_cell axp288_cells[] = { >> .resources = axp288_fuel_gauge_resources, >> }, >> { >> +.name = "axp20x-pek", /*

Re: [PATCH] mfd: axp20x: Add a cell for the power button part of the,axp288 PMICs

2015-10-13 Thread Lee Jones
On Mon, 12 Oct 2015, Borun Fu wrote: > This patch adds the mfd cell info for axp288 power key device. > > Signed-off-by: Borun Fu > Signed-off-by: Fei Yang > --- > drivers/mfd/axp20x.c | 20 > 1 file changed, 20 insertions(+) > > diff --git a/drivers/mfd/axp20x.c b/driv

[PATCH] mfd: axp20x: Add a cell for the power button part of the,axp288 PMICs

2015-10-12 Thread Borun Fu
This patch adds the mfd cell info for axp288 power key device. Signed-off-by: Borun Fu Signed-off-by: Fei Yang --- drivers/mfd/axp20x.c | 20 1 file changed, 20 insertions(+) diff --git a/drivers/mfd/axp20x.c b/drivers/mfd/axp20x.c index 3f576b7..3f4e11f 100644 --- a/dri