Re: [PATCH] mfd: cottula: add cottula board

2014-12-20 Thread Arnd Bergmann
On Saturday 20 December 2014 10:43:48 Robert Jarzmik wrote: > Robert Jarzmik writes: > > Arnd Bergmann writes: > >> This looks a bit ambiguous: You get a GPIO line for the purpose of the > >> IRQ nesting but don't use the GPIO otherwise, and you pass the device's > >> own irq domain start as an I

Re: [PATCH] mfd: cottula: add cottula board

2014-12-20 Thread Robert Jarzmik
Robert Jarzmik writes: > Arnd Bergmann writes: > >> On Monday 15 December 2014 00:10:06 Robert Jarzmik wrote: >>> + >>> + platform_set_drvdata(pdev, cot); >>> + cot->gpio0 = gpiod_get(&pdev->dev, "lubbock_irq", 0); >>> + if (IS_ERR(cot->gpio0)) { >>> + dev_err(&pd

Re: [PATCH] mfd: cottula: add cottula board

2014-12-15 Thread Robert Jarzmik
Arnd Bergmann writes: >> Will that look correct ? > > I'd still prefer the platform data, but this seems good enough and I > see no serious problems with it. OK, so I'll try with the 2 resources. If I'm bitten afterwards and am forced to have a platform data, you'll tell me "I had warned you" ;)

Re: [PATCH] mfd: cottula: add cottula board

2014-12-15 Thread Arnd Bergmann
On Monday 15 December 2014 16:45:03 Robert Jarzmik wrote: > Arnd Bergmann writes: > > > On Monday 15 December 2014 00:10:06 Robert Jarzmik wrote: > >> + > >> + platform_set_drvdata(pdev, cot); > >> + cot->gpio0 = gpiod_get(&pdev->dev, "lubbock_irq", 0); > >> + if (IS_ERR(cot->gp

Re: [PATCH] mfd: cottula: add cottula board

2014-12-15 Thread Robert Jarzmik
Arnd Bergmann writes: > On Monday 15 December 2014 00:10:06 Robert Jarzmik wrote: >> + >> + platform_set_drvdata(pdev, cot); >> + cot->gpio0 = gpiod_get(&pdev->dev, "lubbock_irq", 0); >> + if (IS_ERR(cot->gpio0)) { >> + dev_err(&pdev->dev, "Couldn't request GPIO :

Re: [PATCH] mfd: cottula: add cottula board

2014-12-15 Thread Arnd Bergmann
On Monday 15 December 2014 00:10:06 Robert Jarzmik wrote: > + > + platform_set_drvdata(pdev, cot); > + cot->gpio0 = gpiod_get(&pdev->dev, "lubbock_irq", 0); > + if (IS_ERR(cot->gpio0)) { > + dev_err(&pdev->dev, "Couldn't request GPIO : ret = %d\n", > ret); > +

[PATCH] mfd: cottula: add cottula board

2014-12-14 Thread Robert Jarzmik
Cottula board is the IO motherboard of the Intel PXA25x Development Platform, which supports the Lubbock pxa25x soc board. Historically, this support was in arch/arm/mach-pxa/lubbock.c. When gpio-pxa was moved to drivers/pxa, it became a driver, and its initialization and probing happened at postc