Re: [PATCH] mfd: cros_ec_dev: Don't advertise junk features on failure

2018-06-04 Thread Lee Jones
On Wed, 30 May 2018, Stephen Boyd wrote: > If the feature query fails during this driver's probe, we memset the > features bits to 0, but then we continue to overwrite that with whatever > junk we read back when the feature probing failed. In the case of a SPI > device, it may be complete junk, ca

Re: [PATCH] mfd: cros_ec_dev: Don't advertise junk features on failure

2018-05-31 Thread Benson Leung
Hi Stephen, On Wed, May 30, 2018 at 11:23:43PM -0700, Stephen Boyd wrote: > If the feature query fails during this driver's probe, we memset the > features bits to 0, but then we continue to overwrite that with whatever > junk we read back when the feature probing failed. In the case of a SPI > de

[PATCH] mfd: cros_ec_dev: Don't advertise junk features on failure

2018-05-30 Thread Stephen Boyd
If the feature query fails during this driver's probe, we memset the features bits to 0, but then we continue to overwrite that with whatever junk we read back when the feature probing failed. In the case of a SPI device, it may be complete junk, causing the caller of this function to think certain