Re: [PATCH] mfd: palmas: initialise client->of_node for dummy created client

2013-04-08 Thread Samuel Ortiz
Hi Laxman, On Tue, Mar 19, 2013 at 02:28:20PM +0530, Laxman Dewangan wrote: > Palmas device have three different i2c addresses. The device creates > the two new dummy i2c clients for accessing the register by using > primary client adapter. This new dummy i2c client have their of_node > as NULL. >

Re: [PATCH] mfd: palmas: initialise client->of_node for dummy created client

2013-04-08 Thread Laxman Dewangan
On Wednesday 20 March 2013 08:09 PM, Laxman Dewangan wrote: On Tuesday 19 March 2013 10:56 PM, Mark Brown wrote: * PGP Signed by an unknown key On Tue, Mar 19, 2013 at 11:10:34AM -0600, Stephen Warren wrote: On 03/19/2013 10:52 AM, Mark Brown wrote: This does then make it more complicated for

Re: [PATCH] mfd: palmas: initialise client->of_node for dummy created client

2013-03-20 Thread Laxman Dewangan
On Tuesday 19 March 2013 10:56 PM, Mark Brown wrote: * PGP Signed by an unknown key On Tue, Mar 19, 2013 at 11:10:34AM -0600, Stephen Warren wrote: On 03/19/2013 10:52 AM, Mark Brown wrote: This does then make it more complicated for all users of I2C as they need to become aware of such device

Re: [PATCH] mfd: palmas: initialise client->of_node for dummy created client

2013-03-19 Thread Stephen Warren
On 03/19/2013 10:52 AM, Mark Brown wrote: > On Tue, Mar 19, 2013 at 09:44:24AM -0600, Stephen Warren wrote: > >> It seems like part of the solution here is to modify the >> i2c_client object itself so that it can directly support devices >> that have multiple I2C addresses; instead of 1 i2c_client

Re: [PATCH] mfd: palmas: initialise client->of_node for dummy created client

2013-03-19 Thread Stephen Warren
On 03/19/2013 02:58 AM, Laxman Dewangan wrote: > Palmas device have three different i2c addresses. The device creates > the two new dummy i2c clients for accessing the register by using > primary client adapter. This new dummy i2c client have their of_node > as NULL. > > The dummy i2c client is us

Re: [PATCH] mfd: palmas: initialise client->of_node for dummy created client

2013-03-19 Thread Graeme Gregory
I discussed this with Grant Likely and we came to the same conclusion that this was the only way to "fix" the issue. But his concern was because dummys have a probe/remove of their own this might cause issues in some cases. His opinion was to do this the probe/remove of the dummys should also be re

[PATCH] mfd: palmas: initialise client->of_node for dummy created client

2013-03-19 Thread Laxman Dewangan
Palmas device have three different i2c addresses. The device creates the two new dummy i2c clients for accessing the register by using primary client adapter. This new dummy i2c client have their of_node as NULL. The dummy i2c client is used for registering interrupt and on this, it creates irq do