Re: [PATCH] mfd: sec-core: Fix uninitialized 'regmap_rtc' on S2MPA01

2014-04-06 Thread Geert Uytterhoeven
On Wed, Mar 19, 2014 at 9:27 AM, Sachin Kamat wrote: > On 18 March 2014 18:41, Krzysztof Kozlowski wrote: >> Initialize the 'regmap_rtc' on S2MPA01 to some sane value. Sane at least >> for S5M87X chipsets, not S2MPS/S2MPA but it won't be used because >> rtc-s5m driver does not support S2MPA01. >>

Re: [PATCH] mfd: sec-core: Fix uninitialized 'regmap_rtc' on S2MPA01

2014-03-19 Thread Krzysztof Kozlowski
On Wed, 2014-03-19 at 09:14 +, Lee Jones wrote: > > Initialize the 'regmap_rtc' on S2MPA01 to some sane value. Sane at least > > for S5M87X chipsets, not S2MPS/S2MPA but it won't be used because > > rtc-s5m driver does not support S2MPA01. > > > > This fixes following error: > > drivers/mfd/se

Re: [PATCH] mfd: sec-core: Fix uninitialized 'regmap_rtc' on S2MPA01

2014-03-19 Thread Lee Jones
> Initialize the 'regmap_rtc' on S2MPA01 to some sane value. Sane at least > for S5M87X chipsets, not S2MPS/S2MPA but it won't be used because > rtc-s5m driver does not support S2MPA01. > > This fixes following error: > drivers/mfd/sec-core.c:342:45: warning: ‘regmap_rtc’ may be used > uninitiali

Re: [PATCH] mfd: sec-core: Fix uninitialized 'regmap_rtc' on S2MPA01

2014-03-19 Thread Krzysztof Kozlowski
On Wed, 2014-03-19 at 13:57 +0530, Sachin Kamat wrote: > On 18 March 2014 18:41, Krzysztof Kozlowski wrote: > > Initialize the 'regmap_rtc' on S2MPA01 to some sane value. Sane at least > > for S5M87X chipsets, not S2MPS/S2MPA but it won't be used because > > rtc-s5m driver does not support S2MPA01

Re: [PATCH] mfd: sec-core: Fix uninitialized 'regmap_rtc' on S2MPA01

2014-03-19 Thread Sachin Kamat
On 18 March 2014 18:41, Krzysztof Kozlowski wrote: > Initialize the 'regmap_rtc' on S2MPA01 to some sane value. Sane at least > for S5M87X chipsets, not S2MPS/S2MPA but it won't be used because > rtc-s5m driver does not support S2MPA01. > > This fixes following error: > drivers/mfd/sec-core.c:342:

[PATCH] mfd: sec-core: Fix uninitialized 'regmap_rtc' on S2MPA01

2014-03-18 Thread Krzysztof Kozlowski
Initialize the 'regmap_rtc' on S2MPA01 to some sane value. Sane at least for S5M87X chipsets, not S2MPS/S2MPA but it won't be used because rtc-s5m driver does not support S2MPA01. This fixes following error: drivers/mfd/sec-core.c:342:45: warning: ‘regmap_rtc’ may be used uninitialized in this fu