Re: [PATCH] mfd: wm5102: Remove cache_bypass from manual register patching

2014-02-21 Thread Mark Brown
On Fri, Feb 21, 2014 at 09:38:55AM +, Charles Keepax wrote: > I guess there are two parts here applying the hardware patch and > the manual application of the register patch. Applying the > hardware patch restores registers once it is finished anyway, and > the actual patch is applied by the w

Re: [PATCH] mfd: wm5102: Remove cache_bypass from manual register patching

2014-02-21 Thread Charles Keepax
On Fri, Feb 21, 2014 at 09:38:55AM +, Charles Keepax wrote: > On Fri, Feb 21, 2014 at 08:30:58AM +0900, Mark Brown wrote: > > On Thu, Feb 20, 2014 at 04:26:48PM +, Charles Keepax wrote: > > > > > As the cache_bypass is not strictly necessary for applying the patches > > > (the device is al

Re: [PATCH] mfd: wm5102: Remove cache_bypass from manual register patching

2014-02-21 Thread Charles Keepax
On Fri, Feb 21, 2014 at 08:30:58AM +0900, Mark Brown wrote: > On Thu, Feb 20, 2014 at 04:26:48PM +, Charles Keepax wrote: > > > As the cache_bypass is not strictly necessary for applying the patches > > (the device is always powered on whilst it is applied) remove the calls > > to regcache_cac

Re: [PATCH] mfd: wm5102: Remove cache_bypass from manual register patching

2014-02-20 Thread Mark Brown
On Thu, Feb 20, 2014 at 04:26:48PM +, Charles Keepax wrote: > As the cache_bypass is not strictly necessary for applying the patches > (the device is always powered on whilst it is applied) remove the calls > to regcache_cache_bypass to avoid this situation. That's not why the cache bypass is

[PATCH] mfd: wm5102: Remove cache_bypass from manual register patching

2014-02-20 Thread Charles Keepax
On the wm5102 the register patches are applied manually, rather than by the regmap core. This application is wrapped in calls to regcache_cache_bypass. However, this is dangerous as other threads may be accessing the hardware at the same time as the pm_runtime operations and if they do so during th