Re: [PATCH] mips: lib: uncached: fix uninitialized variable 'sp'

2020-12-06 Thread Maciej W. Rozycki
On Sun, 6 Dec 2020, Maciej W. Rozycki wrote: > I think this should be OK once the issues I mentioned here have been > addressed. Or alternatively making the variable global would possibly be a better fix as it would let the compiler decide if to waste another register to keep a copy of $sp.

Re: [PATCH] mips: lib: uncached: fix uninitialized variable 'sp'

2020-12-06 Thread Maciej W. Rozycki
On Fri, 27 Nov 2020, Anders Roxell wrote: > When building mips tinyconfig with clang the following warning show up: > > /tmp/arch/mips/lib/uncached.c:40:18: note: initialize the variable 'sp' to > silence this warning > register long sp __asm__("$sp"); > ^ >

Re: [PATCH] mips: lib: uncached: fix uninitialized variable 'sp'

2020-11-30 Thread Anders Roxell
On Mon, 30 Nov 2020 at 21:22, Nick Desaulniers wrote: > > On Fri, Nov 27, 2020 at 12:39 AM Anders Roxell > wrote: > > > > When building mips tinyconfig with clang the following warning show up: > > > > /tmp/arch/mips/lib/uncached.c:40:18: note: initialize the variable 'sp' to > > silence this w

Re: [PATCH] mips: lib: uncached: fix uninitialized variable 'sp'

2020-11-30 Thread Nick Desaulniers
On Fri, Nov 27, 2020 at 12:39 AM Anders Roxell wrote: > > When building mips tinyconfig with clang the following warning show up: > > /tmp/arch/mips/lib/uncached.c:40:18: note: initialize the variable 'sp' to > silence this warning > register long sp __asm__("$sp"); >

[PATCH] mips: lib: uncached: fix uninitialized variable 'sp'

2020-11-27 Thread Anders Roxell
When building mips tinyconfig with clang the following warning show up: /tmp/arch/mips/lib/uncached.c:40:18: note: initialize the variable 'sp' to silence this warning register long sp __asm__("$sp"); ^ = 0 Rework to make an explicit inlin