Re: [PATCH] misc: hisi_hikey_usb: use PTR_ERR_OR_ZERO

2020-11-02 Thread John Stultz
On Mon, Oct 26, 2020 at 11:02 AM Sudip Mukherjee wrote: > > Coccinelle suggested using PTR_ERR_OR_ZERO() and looking at the code, > we can use PTR_ERR_OR_ZERO() instead of checking IS_ERR() and then > doing 'return 0'. > > Signed-off-by: Sudip Mukherjee Thanks for sending this! Acked-by: John S

Re: [linux-safety] [PATCH] misc: hisi_hikey_usb: use PTR_ERR_OR_ZERO

2020-10-27 Thread Lukas Bulwahn
On Mon, 26 Oct 2020, Sudip Mukherjee wrote: > Coccinelle suggested using PTR_ERR_OR_ZERO() and looking at the code, > we can use PTR_ERR_OR_ZERO() instead of checking IS_ERR() and then > doing 'return 0'. > > Signed-off-by: Sudip Mukherjee A nice small local clean up. Here is my test report

[PATCH] misc: hisi_hikey_usb: use PTR_ERR_OR_ZERO

2020-10-26 Thread Sudip Mukherjee
Coccinelle suggested using PTR_ERR_OR_ZERO() and looking at the code, we can use PTR_ERR_OR_ZERO() instead of checking IS_ERR() and then doing 'return 0'. Signed-off-by: Sudip Mukherjee --- drivers/misc/hisi_hikey_usb.c | 5 + 1 file changed, 1 insertion(+), 4 deletions(-) diff --git a/driv