Re: [PATCH] misplaced pci_enable_device()s in drivers/sound/

2001-04-18 Thread Marcus Meissner
On Wed, Apr 18, 2001 at 12:55:50PM -0400, Jeff Garzik wrote: > Marcus Meissner wrote: > > Several pci_enable_device()s in drivers/sound happen _after_ accessing > > PCI resources. I have moved them before the relevant first accesses. > > cool > > > if (!RSRCISIOREGION(pcidev, 0)) > >

Re: [PATCH] misplaced pci_enable_device()s in drivers/sound/

2001-04-18 Thread Jeff Garzik
Marcus Meissner wrote: > Several pci_enable_device()s in drivers/sound happen _after_ accessing > PCI resources. I have moved them before the relevant first accesses. cool > if (!RSRCISIOREGION(pcidev, 0)) > return -1; can you replace this mess while you are cleaning

[PATCH] misplaced pci_enable_device()s in drivers/sound/

2001-04-18 Thread Marcus Meissner
Hi, Several pci_enable_device()s in drivers/sound happen _after_ accessing PCI resources. I have moved them before the relevant first accesses. (Untested, but should work.) Against 2.4.3-ac9. Ciao, Marcus Index: es1370.c ===

[PATCH] misplaced pci_enable_device()s in drivers/sound/

2001-04-18 Thread Marcus Meissner
Hi, Several pci_enable_device()s in drivers/sound happen _after_ accessing PCI resources. I have moved them before the relevant first accesses. (Untested, but should work.) Against 2.4.3-ac9. Ciao, Marcus Index: es1370.c ===

Re: [PATCH] misplaced pci_enable_device()s in drivers/sound/

2001-04-18 Thread Jeff Garzik
Marcus Meissner wrote: Several pci_enable_device()s in drivers/sound happen _after_ accessing PCI resources. I have moved them before the relevant first accesses. cool if (!RSRCISIOREGION(pcidev, 0)) return -1; can you replace this mess while you are cleaning stuff

Re: [PATCH] misplaced pci_enable_device()s in drivers/sound/

2001-04-18 Thread Marcus Meissner
On Wed, Apr 18, 2001 at 12:55:50PM -0400, Jeff Garzik wrote: Marcus Meissner wrote: Several pci_enable_device()s in drivers/sound happen _after_ accessing PCI resources. I have moved them before the relevant first accesses. cool if (!RSRCISIOREGION(pcidev, 0))