Re: [PATCH] mlx4: set carrier off after register netdev

2012-10-05 Thread Min Zhang
On Fri, 5 Oct 2012, Ben Hutchings wrote: > On Fri, 2012-10-05 at 11:28 -0700, Min Zhang wrote: > > ifconfig mlx4_en port reported RUNNING even though the link was down. > > > > mlx4_en_init_netdev didn't initialize the dev operstate properly so > > the operstate stayed as default IF_OPER_UNKNOWN

Re: [PATCH] mlx4: set carrier off after register netdev

2012-10-05 Thread Ben Hutchings
On Fri, 2012-10-05 at 11:28 -0700, Min Zhang wrote: > ifconfig mlx4_en port reported RUNNING even though the link was down. > > mlx4_en_init_netdev didn't initialize the dev operstate properly so > the operstate stayed as default IF_OPER_UNKNOWN, then ifconfig treated > the UNKNOWN as RUNNING stat

[PATCH] mlx4: set carrier off after register netdev

2012-10-05 Thread Min Zhang
ifconfig mlx4_en port reported RUNNING even though the link was down. mlx4_en_init_netdev didn't initialize the dev operstate properly so the operstate stayed as default IF_OPER_UNKNOWN, then ifconfig treated the UNKNOWN as RUNNING state for backward compatiblity per RFC2863. The fix calls netif_