Re: [RFC PATCH] mm, compaction: allow compaction for GFP_NOFS requests

On Tue 18-10-16 17:24:46, Dave Chinner wrote: > On Mon, Oct 17, 2016 at 10:22:56AM +0200, Michal Hocko wrote: > > On Mon 17-10-16 07:49:59, Dave Chinner wrote: > > > On Thu, Oct 13, 2016 at 01:04:56PM +0200, Michal Hocko wrote: > > > > On Thu 13-10-16 09:39:47, Michal Hocko wrote: > > > > > On Thu

Re: [RFC PATCH] mm, compaction: allow compaction for GFP_NOFS requests

On Tue 18-10-16 17:24:46, Dave Chinner wrote: > On Mon, Oct 17, 2016 at 10:22:56AM +0200, Michal Hocko wrote: > > On Mon 17-10-16 07:49:59, Dave Chinner wrote: > > > On Thu, Oct 13, 2016 at 01:04:56PM +0200, Michal Hocko wrote: > > > > On Thu 13-10-16 09:39:47, Michal Hocko wrote: > > > > > On Thu

Re: [RFC PATCH] mm, compaction: allow compaction for GFP_NOFS requests

On Mon, Oct 17, 2016 at 10:22:56AM +0200, Michal Hocko wrote: > On Mon 17-10-16 07:49:59, Dave Chinner wrote: > > On Thu, Oct 13, 2016 at 01:04:56PM +0200, Michal Hocko wrote: > > > On Thu 13-10-16 09:39:47, Michal Hocko wrote: > > > > On Thu 13-10-16 11:29:24, Dave Chinner wrote: > > > > > On

Re: [RFC PATCH] mm, compaction: allow compaction for GFP_NOFS requests

On Mon, Oct 17, 2016 at 10:22:56AM +0200, Michal Hocko wrote: > On Mon 17-10-16 07:49:59, Dave Chinner wrote: > > On Thu, Oct 13, 2016 at 01:04:56PM +0200, Michal Hocko wrote: > > > On Thu 13-10-16 09:39:47, Michal Hocko wrote: > > > > On Thu 13-10-16 11:29:24, Dave Chinner wrote: > > > > > On

Re: [RFC PATCH] mm, compaction: allow compaction for GFP_NOFS requests

On Mon 17-10-16 07:49:59, Dave Chinner wrote: > On Thu, Oct 13, 2016 at 01:04:56PM +0200, Michal Hocko wrote: > > On Thu 13-10-16 09:39:47, Michal Hocko wrote: > > > On Thu 13-10-16 11:29:24, Dave Chinner wrote: > > > > On Fri, Oct 07, 2016 at 03:18:14PM +0200, Michal Hocko wrote: > > > [...] > >

Re: [RFC PATCH] mm, compaction: allow compaction for GFP_NOFS requests

On Mon 17-10-16 07:49:59, Dave Chinner wrote: > On Thu, Oct 13, 2016 at 01:04:56PM +0200, Michal Hocko wrote: > > On Thu 13-10-16 09:39:47, Michal Hocko wrote: > > > On Thu 13-10-16 11:29:24, Dave Chinner wrote: > > > > On Fri, Oct 07, 2016 at 03:18:14PM +0200, Michal Hocko wrote: > > > [...] > >

Re: [RFC PATCH] mm, compaction: allow compaction for GFP_NOFS requests

On Thu, Oct 13, 2016 at 01:04:56PM +0200, Michal Hocko wrote: > On Thu 13-10-16 09:39:47, Michal Hocko wrote: > > On Thu 13-10-16 11:29:24, Dave Chinner wrote: > > > On Fri, Oct 07, 2016 at 03:18:14PM +0200, Michal Hocko wrote: > > [...] > > > > Unpatched kernel: > > > > # Version 3.3, 16

Re: [RFC PATCH] mm, compaction: allow compaction for GFP_NOFS requests

On Thu, Oct 13, 2016 at 01:04:56PM +0200, Michal Hocko wrote: > On Thu 13-10-16 09:39:47, Michal Hocko wrote: > > On Thu 13-10-16 11:29:24, Dave Chinner wrote: > > > On Fri, Oct 07, 2016 at 03:18:14PM +0200, Michal Hocko wrote: > > [...] > > > > Unpatched kernel: > > > > # Version 3.3, 16

Re: [RFC PATCH] mm, compaction: allow compaction for GFP_NOFS requests

On Thu 13-10-16 09:39:47, Michal Hocko wrote: > On Thu 13-10-16 11:29:24, Dave Chinner wrote: > > On Fri, Oct 07, 2016 at 03:18:14PM +0200, Michal Hocko wrote: > [...] > > > Unpatched kernel: > > > # Version 3.3, 16 thread(s) starting at Fri Oct 7 09:55:05 2016 > > > # Sync method: NO

Re: [RFC PATCH] mm, compaction: allow compaction for GFP_NOFS requests

On Thu 13-10-16 09:39:47, Michal Hocko wrote: > On Thu 13-10-16 11:29:24, Dave Chinner wrote: > > On Fri, Oct 07, 2016 at 03:18:14PM +0200, Michal Hocko wrote: > [...] > > > Unpatched kernel: > > > # Version 3.3, 16 thread(s) starting at Fri Oct 7 09:55:05 2016 > > > # Sync method: NO

Re: [RFC PATCH] mm, compaction: allow compaction for GFP_NOFS requests

On Thu 13-10-16 11:29:24, Dave Chinner wrote: > On Fri, Oct 07, 2016 at 03:18:14PM +0200, Michal Hocko wrote: [...] > > Unpatched kernel: > > # Version 3.3, 16 thread(s) starting at Fri Oct 7 09:55:05 2016 > > # Sync method: NO SYNC: Test does not issue sync() or fsync() calls. > > #

Re: [RFC PATCH] mm, compaction: allow compaction for GFP_NOFS requests

On Thu 13-10-16 11:29:24, Dave Chinner wrote: > On Fri, Oct 07, 2016 at 03:18:14PM +0200, Michal Hocko wrote: [...] > > Unpatched kernel: > > # Version 3.3, 16 thread(s) starting at Fri Oct 7 09:55:05 2016 > > # Sync method: NO SYNC: Test does not issue sync() or fsync() calls. > > #

Re: [PATCH] mm, compaction: allow compaction for GFP_NOFS requests

On Thu 13-10-16 08:19:53, Vlastimil Babka wrote: > On 10/12/2016 01:47 PM, Michal Hocko wrote: [...] > Acked-by: Vlastimil Babka Thanks! > > Small nitpick below. > > > @@ -1696,14 +1703,16 @@ enum compact_result try_to_compact_pages(gfp_t > > gfp_mask, unsigned int order, > >

Re: [PATCH] mm, compaction: allow compaction for GFP_NOFS requests

On Thu 13-10-16 08:19:53, Vlastimil Babka wrote: > On 10/12/2016 01:47 PM, Michal Hocko wrote: [...] > Acked-by: Vlastimil Babka Thanks! > > Small nitpick below. > > > @@ -1696,14 +1703,16 @@ enum compact_result try_to_compact_pages(gfp_t > > gfp_mask, unsigned int order, > >

Re: [PATCH] mm, compaction: allow compaction for GFP_NOFS requests

On 10/12/2016 01:47 PM, Michal Hocko wrote: From: Michal Hocko compaction has been disabled for GFP_NOFS and GFP_NOIO requests since the direct compaction was introduced by 56de7263fcf3 ("mm: compaction: direct compact when a high-order allocation fails"). The main reason is

Re: [PATCH] mm, compaction: allow compaction for GFP_NOFS requests

On 10/12/2016 01:47 PM, Michal Hocko wrote: From: Michal Hocko compaction has been disabled for GFP_NOFS and GFP_NOIO requests since the direct compaction was introduced by 56de7263fcf3 ("mm: compaction: direct compact when a high-order allocation fails"). The main reason is that the migration

Re: [RFC PATCH] mm, compaction: allow compaction for GFP_NOFS requests

On Fri, Oct 07, 2016 at 03:18:14PM +0200, Michal Hocko wrote: > On Thu 06-10-16 13:11:42, Dave Chinner wrote: > > On Wed, Oct 05, 2016 at 01:38:45PM +0200, Michal Hocko wrote: > > > On Wed 05-10-16 07:32:02, Dave Chinner wrote: > > > > On Tue, Oct 04, 2016 at 10:12:15AM +0200, Michal Hocko wrote:

Re: [RFC PATCH] mm, compaction: allow compaction for GFP_NOFS requests

On Fri, Oct 07, 2016 at 03:18:14PM +0200, Michal Hocko wrote: > On Thu 06-10-16 13:11:42, Dave Chinner wrote: > > On Wed, Oct 05, 2016 at 01:38:45PM +0200, Michal Hocko wrote: > > > On Wed 05-10-16 07:32:02, Dave Chinner wrote: > > > > On Tue, Oct 04, 2016 at 10:12:15AM +0200, Michal Hocko wrote:

[PATCH] mm, compaction: allow compaction for GFP_NOFS requests

From: Michal Hocko compaction has been disabled for GFP_NOFS and GFP_NOIO requests since the direct compaction was introduced by 56de7263fcf3 ("mm: compaction: direct compact when a high-order allocation fails"). The main reason is that the migration of page cache pages might

[PATCH] mm, compaction: allow compaction for GFP_NOFS requests

From: Michal Hocko compaction has been disabled for GFP_NOFS and GFP_NOIO requests since the direct compaction was introduced by 56de7263fcf3 ("mm: compaction: direct compact when a high-order allocation fails"). The main reason is that the migration of page cache pages might recurse back to

Re: [RFC PATCH] mm, compaction: allow compaction for GFP_NOFS requests

On 10/07/2016 11:21 AM, Michal Hocko wrote: On Fri 07-10-16 10:15:07, Vlastimil Babka wrote: On 10/07/2016 08:50 AM, Michal Hocko wrote: On Fri 07-10-16 07:27:37, Vlastimil Babka wrote: [...] But make sure you don't break kcompactd and manual compaction from /proc, as they don't currently

Re: [RFC PATCH] mm, compaction: allow compaction for GFP_NOFS requests

On 10/07/2016 11:21 AM, Michal Hocko wrote: On Fri 07-10-16 10:15:07, Vlastimil Babka wrote: On 10/07/2016 08:50 AM, Michal Hocko wrote: On Fri 07-10-16 07:27:37, Vlastimil Babka wrote: [...] But make sure you don't break kcompactd and manual compaction from /proc, as they don't currently

Re: [RFC PATCH] mm, compaction: allow compaction for GFP_NOFS requests

On Thu 06-10-16 13:11:42, Dave Chinner wrote: > On Wed, Oct 05, 2016 at 01:38:45PM +0200, Michal Hocko wrote: > > On Wed 05-10-16 07:32:02, Dave Chinner wrote: > > > On Tue, Oct 04, 2016 at 10:12:15AM +0200, Michal Hocko wrote: > > > > From: Michal Hocko > > > > > > > >

Re: [RFC PATCH] mm, compaction: allow compaction for GFP_NOFS requests

On Thu 06-10-16 13:11:42, Dave Chinner wrote: > On Wed, Oct 05, 2016 at 01:38:45PM +0200, Michal Hocko wrote: > > On Wed 05-10-16 07:32:02, Dave Chinner wrote: > > > On Tue, Oct 04, 2016 at 10:12:15AM +0200, Michal Hocko wrote: > > > > From: Michal Hocko > > > > > > > > compaction has been

Re: [RFC PATCH] mm, compaction: allow compaction for GFP_NOFS requests

On Fri 07-10-16 10:15:07, Vlastimil Babka wrote: > On 10/07/2016 08:50 AM, Michal Hocko wrote: > > On Fri 07-10-16 07:27:37, Vlastimil Babka wrote: [...] > > > But make sure you don't break kcompactd and manual compaction from /proc, > > > as > > > they don't currently set cc->gfp_mask. Looks

Re: [RFC PATCH] mm, compaction: allow compaction for GFP_NOFS requests

On Fri 07-10-16 10:15:07, Vlastimil Babka wrote: > On 10/07/2016 08:50 AM, Michal Hocko wrote: > > On Fri 07-10-16 07:27:37, Vlastimil Babka wrote: [...] > > > But make sure you don't break kcompactd and manual compaction from /proc, > > > as > > > they don't currently set cc->gfp_mask. Looks

Re: [RFC PATCH] mm, compaction: allow compaction for GFP_NOFS requests

On 10/07/2016 08:50 AM, Michal Hocko wrote: On Fri 07-10-16 07:27:37, Vlastimil Babka wrote: [...] diff --git a/mm/compaction.c b/mm/compaction.c index badb92bf14b4..07254a73ee32 100644 --- a/mm/compaction.c +++ b/mm/compaction.c @@ -834,6 +834,13 @@ isolate_migratepages_block(struct

Re: [RFC PATCH] mm, compaction: allow compaction for GFP_NOFS requests

On 10/07/2016 08:50 AM, Michal Hocko wrote: On Fri 07-10-16 07:27:37, Vlastimil Babka wrote: [...] diff --git a/mm/compaction.c b/mm/compaction.c index badb92bf14b4..07254a73ee32 100644 --- a/mm/compaction.c +++ b/mm/compaction.c @@ -834,6 +834,13 @@ isolate_migratepages_block(struct

Re: [RFC PATCH] mm, compaction: allow compaction for GFP_NOFS requests

On Fri 07-10-16 07:27:37, Vlastimil Babka wrote: [...] > > diff --git a/mm/compaction.c b/mm/compaction.c > > index badb92bf14b4..07254a73ee32 100644 > > --- a/mm/compaction.c > > +++ b/mm/compaction.c > > @@ -834,6 +834,13 @@ isolate_migratepages_block(struct compact_control *cc, > > unsigned

Re: [RFC PATCH] mm, compaction: allow compaction for GFP_NOFS requests

On Fri 07-10-16 07:27:37, Vlastimil Babka wrote: [...] > > diff --git a/mm/compaction.c b/mm/compaction.c > > index badb92bf14b4..07254a73ee32 100644 > > --- a/mm/compaction.c > > +++ b/mm/compaction.c > > @@ -834,6 +834,13 @@ isolate_migratepages_block(struct compact_control *cc, > > unsigned

Re: [RFC PATCH] mm, compaction: allow compaction for GFP_NOFS requests

On 10/04/2016 10:12 AM, Michal Hocko wrote: From: Michal Hocko compaction has been disabled for GFP_NOFS and GFP_NOIO requests since the direct compaction was introduced by 56de7263fcf3 ("mm: compaction: direct compact when a high-order allocation fails"). The main reason is

Re: [RFC PATCH] mm, compaction: allow compaction for GFP_NOFS requests

On 10/04/2016 10:12 AM, Michal Hocko wrote: From: Michal Hocko compaction has been disabled for GFP_NOFS and GFP_NOIO requests since the direct compaction was introduced by 56de7263fcf3 ("mm: compaction: direct compact when a high-order allocation fails"). The main reason is that the migration

Re: [RFC PATCH] mm, compaction: allow compaction for GFP_NOFS requests

On Wed, Oct 05, 2016 at 01:38:45PM +0200, Michal Hocko wrote: > On Wed 05-10-16 07:32:02, Dave Chinner wrote: > > On Tue, Oct 04, 2016 at 10:12:15AM +0200, Michal Hocko wrote: > > > From: Michal Hocko > > > > > > compaction has been disabled for GFP_NOFS and GFP_NOIO requests

Re: [RFC PATCH] mm, compaction: allow compaction for GFP_NOFS requests

On Wed, Oct 05, 2016 at 01:38:45PM +0200, Michal Hocko wrote: > On Wed 05-10-16 07:32:02, Dave Chinner wrote: > > On Tue, Oct 04, 2016 at 10:12:15AM +0200, Michal Hocko wrote: > > > From: Michal Hocko > > > > > > compaction has been disabled for GFP_NOFS and GFP_NOIO requests since > > > the

Re: [RFC PATCH] mm, compaction: allow compaction for GFP_NOFS requests

On Wed 05-10-16 07:32:02, Dave Chinner wrote: > On Tue, Oct 04, 2016 at 10:12:15AM +0200, Michal Hocko wrote: > > From: Michal Hocko > > > > compaction has been disabled for GFP_NOFS and GFP_NOIO requests since > > the direct compaction was introduced by 56de7263fcf3 ("mm:

Re: [RFC PATCH] mm, compaction: allow compaction for GFP_NOFS requests

On Wed 05-10-16 07:32:02, Dave Chinner wrote: > On Tue, Oct 04, 2016 at 10:12:15AM +0200, Michal Hocko wrote: > > From: Michal Hocko > > > > compaction has been disabled for GFP_NOFS and GFP_NOIO requests since > > the direct compaction was introduced by 56de7263fcf3 ("mm: compaction: > > direct

Re: [RFC PATCH] mm, compaction: allow compaction for GFP_NOFS requests

On Tue, Oct 04, 2016 at 10:12:15AM +0200, Michal Hocko wrote: > From: Michal Hocko > > compaction has been disabled for GFP_NOFS and GFP_NOIO requests since > the direct compaction was introduced by 56de7263fcf3 ("mm: compaction: > direct compact when a high-order allocation

Re: [RFC PATCH] mm, compaction: allow compaction for GFP_NOFS requests

On Tue, Oct 04, 2016 at 10:12:15AM +0200, Michal Hocko wrote: > From: Michal Hocko > > compaction has been disabled for GFP_NOFS and GFP_NOIO requests since > the direct compaction was introduced by 56de7263fcf3 ("mm: compaction: > direct compact when a high-order allocation fails"). The main

[RFC PATCH] mm, compaction: allow compaction for GFP_NOFS requests

From: Michal Hocko compaction has been disabled for GFP_NOFS and GFP_NOIO requests since the direct compaction was introduced by 56de7263fcf3 ("mm: compaction: direct compact when a high-order allocation fails"). The main reason is that the migration of page cache pages might

[RFC PATCH] mm, compaction: allow compaction for GFP_NOFS requests

From: Michal Hocko compaction has been disabled for GFP_NOFS and GFP_NOIO requests since the direct compaction was introduced by 56de7263fcf3 ("mm: compaction: direct compact when a high-order allocation fails"). The main reason is that the migration of page cache pages might recurse back to