Re: [PATCH] mm, compaction: fix NR_ISOLATED_* stats for pfn based migration

2016-10-20 Thread Michal Hocko
On Thu 20-10-16 20:16:06, Andrew Morton wrote: > On Wed, 19 Oct 2016 10:02:40 +0200 Michal Hocko wrote: > > > Since bda807d44454 ("mm: migrate: support non-lru movable page > > migration") isolate_migratepages_block) can isolate !PageLRU pages which > > would acct_isolated account as NR_ISOLATED_

Re: [PATCH] mm, compaction: fix NR_ISOLATED_* stats for pfn based migration

2016-10-20 Thread Andrew Morton
On Wed, 19 Oct 2016 10:02:40 +0200 Michal Hocko wrote: > Since bda807d44454 ("mm: migrate: support non-lru movable page > migration") isolate_migratepages_block) can isolate !PageLRU pages which > would acct_isolated account as NR_ISOLATED_*. Accounting these non-lru > pages NR_ISOLATED_{ANON,FIL

[PATCH] mm, compaction: fix NR_ISOLATED_* stats for pfn based migration

2016-10-19 Thread Michal Hocko
From: Ming Ling Since bda807d44454 ("mm: migrate: support non-lru movable page migration") isolate_migratepages_block) can isolate !PageLRU pages which would acct_isolated account as NR_ISOLATED_*. Accounting these non-lru pages NR_ISOLATED_{ANON,FILE} doesn't make any sense and it can misguide h

Re: [PATCH] mm, compaction: fix NR_ISOLATED_* stats for pfn based migration

2016-10-19 Thread Vlastimil Babka
On 10/19/2016 10:02 AM, Michal Hocko wrote: From: Ming Ling Since bda807d44454 ("mm: migrate: support non-lru movable page migration") isolate_migratepages_block) can isolate !PageLRU pages which would acct_isolated account as NR_ISOLATED_*. Accounting these non-lru pages NR_ISOLATED_{ANON,FILE

Re: [PATCH] mm, compaction: fix NR_ISOLATED_* stats for pfn based migration

2016-10-19 Thread Michal Hocko
On Wed 19-10-16 11:39:36, Vlastimil Babka wrote: > On 10/19/2016 10:02 AM, Michal Hocko wrote: > > From: Ming Ling > > > > Since bda807d44454 ("mm: migrate: support non-lru movable page > > migration") isolate_migratepages_block) can isolate !PageLRU pages which > > would acct_isolated account as