Re: [PATCH] mm, hugetlb: gimme back my page

2014-01-31 Thread Davidlohr Bueso
On Thu, 2014-01-30 at 12:58 -0800, David Rientjes wrote: > On Thu, 30 Jan 2014, Sasha Levin wrote: > > > VM_BUG_ON_PAGE is just a VM_BUG_ON that does dump_page before the BUG(). > > > > The only reason to use VM_BUG_ON instead of VM_BUG_ON_PAGE is if the page > > you're working > > with doesn't m

Re: [PATCH] mm, hugetlb: gimme back my page

2014-01-30 Thread David Rientjes
On Thu, 30 Jan 2014, Sasha Levin wrote: > VM_BUG_ON_PAGE is just a VM_BUG_ON that does dump_page before the BUG(). > > The only reason to use VM_BUG_ON instead of VM_BUG_ON_PAGE is if the page > you're working > with doesn't make sense/isn't useful as debug output. > > If doing a dump_page is ca

Re: [PATCH] mm, hugetlb: gimme back my page

2014-01-30 Thread Davidlohr Bueso
On Thu, 2014-01-30 at 10:59 +0100, Michal Hocko wrote: > On Wed 29-01-14 22:37:03, Davidlohr Bueso wrote: > > From: Davidlohr Bueso > > > > While testing some changes, I noticed an issue triggered by the libhugetlbfs > > test-suite. This is caused by commit 309381fe (mm: dump page when hitting a

Re: [PATCH] mm, hugetlb: gimme back my page

2014-01-30 Thread Sasha Levin
On 01/30/2014 01:37 AM, Davidlohr Bueso wrote: From: Davidlohr Bueso While testing some changes, I noticed an issue triggered by the libhugetlbfs test-suite. This is caused by commit 309381fe (mm: dump page when hitting a VM_BUG_ON using VM_BUG_ON_PAGE), where an application can unexpectedly OOM

Re: [PATCH] mm, hugetlb: gimme back my page

2014-01-30 Thread Michal Hocko
On Wed 29-01-14 22:37:03, Davidlohr Bueso wrote: > From: Davidlohr Bueso > > While testing some changes, I noticed an issue triggered by the libhugetlbfs > test-suite. This is caused by commit 309381fe (mm: dump page when hitting a > VM_BUG_ON using VM_BUG_ON_PAGE), where an application can unexp

[PATCH] mm, hugetlb: gimme back my page

2014-01-29 Thread Davidlohr Bueso
From: Davidlohr Bueso While testing some changes, I noticed an issue triggered by the libhugetlbfs test-suite. This is caused by commit 309381fe (mm: dump page when hitting a VM_BUG_ON using VM_BUG_ON_PAGE), where an application can unexpectedly OOM due to another program that using, or reserving