Re: [PATCH] mm, memory_hotplug: Fix the wrong usage of N_HIGH_MEMORY

2019-03-20 Thread Michal Hocko
On Wed 20-03-19 12:12:09, Andrew Morton wrote: > On Wed, 20 Mar 2019 16:07:32 +0800 Baoquan He wrote: > > > In function node_states_check_changes_online(), N_HIGH_MEMORY is used > > to substitute ZONE_HIGHMEM directly. This is not right. N_HIGH_MEMORY > > always has value '3' if CONFIG_HIGHMEM=y,

Re: [PATCH] mm, memory_hotplug: Fix the wrong usage of N_HIGH_MEMORY

2019-03-20 Thread Andrew Morton
On Wed, 20 Mar 2019 16:07:32 +0800 Baoquan He wrote: > In function node_states_check_changes_online(), N_HIGH_MEMORY is used > to substitute ZONE_HIGHMEM directly. This is not right. N_HIGH_MEMORY > always has value '3' if CONFIG_HIGHMEM=y, while ZONE_HIGHMEM's value > is not. It depends on wheth

Re: [PATCH] mm, memory_hotplug: Fix the wrong usage of N_HIGH_MEMORY

2019-03-20 Thread Oscar Salvador
On Wed, Mar 20, 2019 at 04:07:32PM +0800, Baoquan He wrote: > In function node_states_check_changes_online(), N_HIGH_MEMORY is used > to substitute ZONE_HIGHMEM directly. This is not right. N_HIGH_MEMORY > always has value '3' if CONFIG_HIGHMEM=y, while ZONE_HIGHMEM's value > is not. It depends on

Re: [PATCH] mm, memory_hotplug: Fix the wrong usage of N_HIGH_MEMORY

2019-03-20 Thread Oscar Salvador
On Wed, Mar 20, 2019 at 04:07:32PM +0800, Baoquan He wrote: > In function node_states_check_changes_online(), N_HIGH_MEMORY is used > to substitute ZONE_HIGHMEM directly. This is not right. N_HIGH_MEMORY > always has value '3' if CONFIG_HIGHMEM=y, while ZONE_HIGHMEM's value > is not. It depends on

Re: [PATCH] mm, memory_hotplug: Fix the wrong usage of N_HIGH_MEMORY

2019-03-20 Thread Michal Hocko
On Wed 20-03-19 17:06:24, Baoquan He wrote: > On 03/20/19 at 09:46am, Michal Hocko wrote: > > On Wed 20-03-19 16:07:32, Baoquan He wrote: > > > In function node_states_check_changes_online(), N_HIGH_MEMORY is used > > > to substitute ZONE_HIGHMEM directly. This is not right. N_HIGH_MEMORY > > > alw

Re: [PATCH] mm, memory_hotplug: Fix the wrong usage of N_HIGH_MEMORY

2019-03-20 Thread Baoquan He
On 03/20/19 at 10:11am, David Hildenbrand wrote: > On 20.03.19 10:06, Baoquan He wrote: > > On 03/20/19 at 09:46am, Michal Hocko wrote: > >> On Wed 20-03-19 16:07:32, Baoquan He wrote: > >>> In function node_states_check_changes_online(), N_HIGH_MEMORY is used > >>> to substitute ZONE_HIGHMEM direc

Re: [PATCH] mm, memory_hotplug: Fix the wrong usage of N_HIGH_MEMORY

2019-03-20 Thread David Hildenbrand
On 20.03.19 10:06, Baoquan He wrote: > On 03/20/19 at 09:46am, Michal Hocko wrote: >> On Wed 20-03-19 16:07:32, Baoquan He wrote: >>> In function node_states_check_changes_online(), N_HIGH_MEMORY is used >>> to substitute ZONE_HIGHMEM directly. This is not right. N_HIGH_MEMORY >>> always has value

Re: [PATCH] mm, memory_hotplug: Fix the wrong usage of N_HIGH_MEMORY

2019-03-20 Thread Baoquan He
On 03/20/19 at 09:46am, Michal Hocko wrote: > On Wed 20-03-19 16:07:32, Baoquan He wrote: > > In function node_states_check_changes_online(), N_HIGH_MEMORY is used > > to substitute ZONE_HIGHMEM directly. This is not right. N_HIGH_MEMORY > > always has value '3' if CONFIG_HIGHMEM=y, while ZONE_HIGH

Re: [PATCH] mm, memory_hotplug: Fix the wrong usage of N_HIGH_MEMORY

2019-03-20 Thread Michal Hocko
On Wed 20-03-19 16:07:32, Baoquan He wrote: > In function node_states_check_changes_online(), N_HIGH_MEMORY is used > to substitute ZONE_HIGHMEM directly. This is not right. N_HIGH_MEMORY > always has value '3' if CONFIG_HIGHMEM=y, while ZONE_HIGHMEM's value > is not. It depends on whether CONFIG_Z

[PATCH] mm, memory_hotplug: Fix the wrong usage of N_HIGH_MEMORY

2019-03-20 Thread Baoquan He
In function node_states_check_changes_online(), N_HIGH_MEMORY is used to substitute ZONE_HIGHMEM directly. This is not right. N_HIGH_MEMORY always has value '3' if CONFIG_HIGHMEM=y, while ZONE_HIGHMEM's value is not. It depends on whether CONFIG_ZONE_DMA/CONFIG_ZONE_DMA32 are enabled. Obviously it'