Re: [PATCH] mm, page_alloc: drop pointless static qualifier in build_zonelists()

2019-10-08 Thread Michal Hocko
On Tue 08-10-19 19:06:57, Cristopher Lameter wrote: > On Sat, 28 Sep 2019, Kaitao Cheng wrote: > > > There is no need to make the 'node_order' variable static > > since new value always be assigned before use it. > > In the past MAX_NUMMNODES could become quite large like 512 or 1k. Large > array

Re: [PATCH] mm, page_alloc: drop pointless static qualifier in build_zonelists()

2019-10-08 Thread Christopher Lameter
On Sat, 28 Sep 2019, Kaitao Cheng wrote: > There is no need to make the 'node_order' variable static > since new value always be assigned before use it. In the past MAX_NUMMNODES could become quite large like 512 or 1k. Large array allocations on the stack are problematic. Maybe that is no longe

Re: [PATCH] mm, page_alloc: drop pointless static qualifier in build_zonelists()

2019-09-27 Thread Dan Williams
On Fri, Sep 27, 2019 at 9:14 AM Kaitao Cheng wrote: > > There is no need to make the 'node_order' variable static > since new value always be assigned before use it. > > Signed-off-by: Kaitao Cheng > Signed-off-by: Muchun Song > --- > mm/page_alloc.c | 2 +- > 1 file changed, 1 insertion(+), 1

[PATCH] mm, page_alloc: drop pointless static qualifier in build_zonelists()

2019-09-27 Thread Kaitao Cheng
There is no need to make the 'node_order' variable static since new value always be assigned before use it. Signed-off-by: Kaitao Cheng Signed-off-by: Muchun Song --- mm/page_alloc.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/mm/page_alloc.c b/mm/page_alloc.c index 3334