Re: [PATCH] mm/cma: cma_declare_contiguous: correct err handling

2019-02-26 Thread Catalin Marinas
On Tue, Feb 19, 2019 at 07:46:11PM +0200, Mike Rapoport wrote: > On Tue, Feb 19, 2019 at 05:55:33PM +0100, Vlastimil Babka wrote: > > On 2/14/19 9:38 PM, Andrew Morton wrote: > > > On Thu, 14 Feb 2019 12:45:51 + Peng Fan wrote: > > > > > >> In case cma_init_reserved_mem failed, need to free

Re: [PATCH] mm/cma: cma_declare_contiguous: correct err handling

2019-02-26 Thread Mike Rapoport
edhat.com; mho...@suse.com; > > iamjoonsoo@lge.com; r...@linux.vnet.ibm.com; > > m.szyprow...@samsung.com; rdun...@infradead.org; > > andreyk...@google.com; linux...@kvack.org; linux-kernel@vger.kernel.org; > > van.free...@gmail.com; Catalin Marinas > > Subject: Re: [PAT

RE: [PATCH] mm/cma: cma_declare_contiguous: correct err handling

2019-02-22 Thread Peng Fan
row...@samsung.com; rdun...@infradead.org; > andreyk...@google.com; linux...@kvack.org; linux-kernel@vger.kernel.org; > van.free...@gmail.com; Catalin Marinas > Subject: Re: [PATCH] mm/cma: cma_declare_contiguous: correct err handling > > On Tue, Feb 19, 2019 at 05:55:33PM +0100, Vlastimil Babk

Re: [PATCH] mm/cma: cma_declare_contiguous: correct err handling

2019-02-19 Thread Mike Rapoport
On Tue, Feb 19, 2019 at 05:55:33PM +0100, Vlastimil Babka wrote: > On 2/14/19 9:38 PM, Andrew Morton wrote: > > On Thu, 14 Feb 2019 12:45:51 + Peng Fan wrote: > > > >> In case cma_init_reserved_mem failed, need to free the memblock allocated > >> by memblock_reserve or memblock_alloc_range.

Re: [PATCH] mm/cma: cma_declare_contiguous: correct err handling

2019-02-19 Thread Vlastimil Babka
On 2/14/19 9:38 PM, Andrew Morton wrote: > On Thu, 14 Feb 2019 12:45:51 + Peng Fan wrote: > >> In case cma_init_reserved_mem failed, need to free the memblock allocated >> by memblock_reserve or memblock_alloc_range. >> >> ... >> >> --- a/mm/cma.c >> +++ b/mm/cma.c >> @@ -353,12 +353,14 @@

RE: [PATCH] mm/cma: cma_declare_contiguous: correct err handling

2019-02-14 Thread Peng Fan
rdun...@infradead.org; > andreyk...@google.com; linux...@kvack.org; linux-kernel@vger.kernel.org; > van.free...@gmail.com; Mike Rapoport > Subject: Re: [PATCH] mm/cma: cma_declare_contiguous: correct err handling > > On Thu, 14 Feb 2019 12:45:51 + Peng Fan wrote: > > &g

Re: [PATCH] mm/cma: cma_declare_contiguous: correct err handling

2019-02-14 Thread Andrew Morton
On Thu, 14 Feb 2019 12:45:51 + Peng Fan wrote: > In case cma_init_reserved_mem failed, need to free the memblock allocated > by memblock_reserve or memblock_alloc_range. > > ... > > --- a/mm/cma.c > +++ b/mm/cma.c > @@ -353,12 +353,14 @@ int __init cma_declare_contiguous(phys_addr_t base, >

[PATCH] mm/cma: cma_declare_contiguous: correct err handling

2019-02-14 Thread Peng Fan
In case cma_init_reserved_mem failed, need to free the memblock allocated by memblock_reserve or memblock_alloc_range. Signed-off-by: Peng Fan --- V1: code inspection, I do not met failure in cma_init_reserved_mem. mm/cma.c | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git