Re: [PATCH] mm/compaction: avoid VM_BUG_ON(PageSlab()) in page_mapcount()

2020-06-02 Thread Alex Shi
在 2020/6/2 下午12:05, Hugh Dickins 写道: > Cc'ing Alex Shi, because I noticed this when trying his v11 per-memcg > lru_lock series (which appears to be a big improvement over earlier > versions, thanks in particular to Johannes's memcg swap simplifications); > and Alex's 12/16 makes a change on top

Re: [PATCH] mm/compaction: avoid VM_BUG_ON(PageSlab()) in page_mapcount()

2020-06-01 Thread Andrew Morton
On Mon, 1 Jun 2020 21:05:25 -0700 (PDT) Hugh Dickins wrote: > Andrew, I've noticed that this buggy > mm-compaction-avoid-vm_bug_onpageslab-in-page_mapcount.patch > was still in Friday's mmotm 2020-05-29-16-09, despite its replacement > 6988f31d558a ("mm: remove VM_BUG_ON(PageSlab()) from

Re: [PATCH] mm/compaction: avoid VM_BUG_ON(PageSlab()) in page_mapcount()

2020-06-01 Thread Hugh Dickins
On Sat, 23 May 2020, Hugh Dickins wrote: > On Wed, 13 May 2020, Konstantin Khlebnikov wrote: > > > Function isolate_migratepages_block() runs some checks out of lru_lock > > when choose pages for migration. After checking PageLRU() it checks extra > > page references by comparing page_count() and

Re: [PATCH] mm/compaction: avoid VM_BUG_ON(PageSlab()) in page_mapcount()

2020-05-24 Thread Hugh Dickins
On Sun, 24 May 2020, Konstantin Khlebnikov wrote: > On 24/05/2020 04.01, Hugh Dickins wrote: > > On Wed, 13 May 2020, Konstantin Khlebnikov wrote: > > > > > Function isolate_migratepages_block() runs some checks out of lru_lock > > > when choose pages for migration. After checking PageLRU() it

Re: [PATCH] mm/compaction: avoid VM_BUG_ON(PageSlab()) in page_mapcount()

2020-05-24 Thread Konstantin Khlebnikov
On 24/05/2020 04.01, Hugh Dickins wrote: On Wed, 13 May 2020, Konstantin Khlebnikov wrote: Function isolate_migratepages_block() runs some checks out of lru_lock when choose pages for migration. After checking PageLRU() it checks extra page references by comparing page_count() and

Re: [PATCH] mm/compaction: avoid VM_BUG_ON(PageSlab()) in page_mapcount()

2020-05-23 Thread Hugh Dickins
On Wed, 13 May 2020, Konstantin Khlebnikov wrote: > Function isolate_migratepages_block() runs some checks out of lru_lock > when choose pages for migration. After checking PageLRU() it checks extra > page references by comparing page_count() and page_mapcount(). Between > these two checks page

Re: [PATCH] mm/compaction: avoid VM_BUG_ON(PageSlab()) in page_mapcount()

2020-05-23 Thread Konstantin Khlebnikov
On Sat, May 23, 2020 at 4:34 AM Andrew Morton wrote: > > On Wed, 13 May 2020 17:05:25 +0300 Konstantin Khlebnikov > wrote: > > > Function isolate_migratepages_block() runs some checks out of lru_lock > > when choose pages for migration. After checking PageLRU() it checks extra > > page

Re: [PATCH] mm/compaction: avoid VM_BUG_ON(PageSlab()) in page_mapcount()

2020-05-22 Thread Andrew Morton
On Wed, 13 May 2020 17:05:25 +0300 Konstantin Khlebnikov wrote: > Function isolate_migratepages_block() runs some checks out of lru_lock > when choose pages for migration. After checking PageLRU() it checks extra > page references by comparing page_count() and page_mapcount(). Between > these

Re: [PATCH] mm/compaction: avoid VM_BUG_ON(PageSlab()) in page_mapcount()

2020-05-13 Thread Vlastimil Babka
On 5/13/20 9:28 PM, Konstantin Khlebnikov wrote: > On 13/05/2020 21.32, Andrew Morton wrote: >> On Wed, 13 May 2020 17:05:25 +0300 Konstantin Khlebnikov >> wrote: >> >>> Function isolate_migratepages_block() runs some checks out of lru_lock >>> when choose pages for migration. After checking

Re: [PATCH] mm/compaction: avoid VM_BUG_ON(PageSlab()) in page_mapcount()

2020-05-13 Thread Konstantin Khlebnikov
On 13/05/2020 21.32, Andrew Morton wrote: On Wed, 13 May 2020 17:05:25 +0300 Konstantin Khlebnikov wrote: Function isolate_migratepages_block() runs some checks out of lru_lock when choose pages for migration. After checking PageLRU() it checks extra page references by comparing page_count()

Re: [PATCH] mm/compaction: avoid VM_BUG_ON(PageSlab()) in page_mapcount()

2020-05-13 Thread Andrew Morton
On Wed, 13 May 2020 17:05:25 +0300 Konstantin Khlebnikov wrote: > Function isolate_migratepages_block() runs some checks out of lru_lock > when choose pages for migration. After checking PageLRU() it checks extra > page references by comparing page_count() and page_mapcount(). Between > these

[PATCH] mm/compaction: avoid VM_BUG_ON(PageSlab()) in page_mapcount()

2020-05-13 Thread Konstantin Khlebnikov
Function isolate_migratepages_block() runs some checks out of lru_lock when choose pages for migration. After checking PageLRU() it checks extra page references by comparing page_count() and page_mapcount(). Between these two checks page could be removed from lru, freed and taken by slab. As a