Re: [PATCH] mm/filemap: Drop check for truncated page after I/O

2021-03-04 Thread William Kucharski
LGTM. Reviewed-by: William Kucharski > On Mar 3, 2021, at 3:25 PM, Matthew Wilcox (Oracle) > wrote: > > If the I/O completed successfully, the page will remain Uptodate, > even if it is subsequently truncated. If the I/O completed with an error, > this check would cause us to retry the I/O i

[PATCH] mm/filemap: Drop check for truncated page after I/O

2021-03-03 Thread Matthew Wilcox (Oracle)
If the I/O completed successfully, the page will remain Uptodate, even if it is subsequently truncated. If the I/O completed with an error, this check would cause us to retry the I/O if the page were truncated before we woke up. There is no need to retry the I/O; the I/O to fill the page failed,