Re: [PATCH] mm/hotplug: fix offline undo_isolate_page_range()

2019-03-13 Thread Michal Hocko
On Wed 13-03-19 08:52:16, Oscar Salvador wrote: > On Tue, Mar 12, 2019 at 09:42:16PM -0400, Qian Cai wrote: > > + > > + /* > > +* Onlining will reset pagetype flags and makes migrate type > > +* MOVABLE, so just need to decrease the number of isolated > > +* pageblocks zone counter he

Re: [PATCH] mm/hotplug: fix offline undo_isolate_page_range()

2019-03-13 Thread Oscar Salvador
On Tue, Mar 12, 2019 at 09:42:16PM -0400, Qian Cai wrote: > + > + /* > + * Onlining will reset pagetype flags and makes migrate type > + * MOVABLE, so just need to decrease the number of isolated > + * pageblocks zone counter here. > + */ > + for (pfn = start_pfn; pfn <

[PATCH] mm/hotplug: fix offline undo_isolate_page_range()

2019-03-12 Thread Qian Cai
The commit f1dd2cd13c4b ("mm, memory_hotplug: do not associate hotadded memory to zones until online") introduced move_pfn_range_to_zone() which calls memmap_init_zone() during onlining a memory block. memmap_init_zone() will reset pagetype flags and makes migrate type to be MOVABLE. However, in _