Re: [PATCH] mm/hugetl.c: keep the page mapping info when free_huge_page() hit the VM_BUG_ON_PAGE

2018-11-15 Thread Michal Hocko
On Thu 15-11-18 16:30:32, Yongkai Wu wrote: [...] Thanks for the clarification. It can be helpful for somebody trying to debug a similar issue in the future. > But i can not find a similar bug fix report or commit log. What about 6bc9b56433b7 ("mm: fix race on soft-offlining free huge pages") ?

Re: [PATCH] mm/hugetl.c: keep the page mapping info when free_huge_page() hit the VM_BUG_ON_PAGE

2018-11-13 Thread Mike Kravetz
On 11/13/18 7:12 AM, Yongkai Wu wrote: > Dear Maintainer, > Actually i met a VM_BUG_ON_PAGE issue in centos7.4 some days ago.When the > issue first happen, > i just can know that it happen in free_huge_page() when doing soft offline > huge page. > But because page->mapping is set to null,i can no

Re: [PATCH] mm/hugetl.c: keep the page mapping info when free_huge_page() hit the VM_BUG_ON_PAGE

2018-11-13 Thread Michal Hocko
[Please do not top-post] On Tue 13-11-18 23:12:24, Yongkai Wu wrote: > Dear Maintainer, > Actually i met a VM_BUG_ON_PAGE issue in centos7.4 some days ago.When the > issue first happen, > i just can know that it happen in free_huge_page() when doing soft offline > huge page. > But because page->ma

Re: [PATCH] mm/hugetl.c: keep the page mapping info when free_huge_page() hit the VM_BUG_ON_PAGE

2018-11-13 Thread Michal Hocko
On Tue 13-11-18 20:38:16, Yongkai Wu wrote: > It is better to keep page mapping info when free_huge_page() hit the > VM_BUG_ON_PAGE, > so we can get more infomation from the coredump for further analysis. The patch seems to be whitespace damaged. Put that aside, have you actually seen a case where