Re: [PATCH] mm/hugetlb: Get rid of NODEMASK_ALLOC

2019-04-03 Thread Baoquan He
On 04/02/19 at 03:34pm, Oscar Salvador wrote: > NODEMASK_ALLOC is used to allocate a nodemask bitmap, ant it does it by ~ and > first determining whether it should be allocated in the stack or dinamically

Re: [PATCH] mm/hugetlb: Get rid of NODEMASK_ALLOC

2019-04-02 Thread Naoya Horiguchi
On Tue, Apr 02, 2019 at 03:34:15PM +0200, Oscar Salvador wrote: > NODEMASK_ALLOC is used to allocate a nodemask bitmap, ant it does it by > first determining whether it should be allocated in the stack or dinamically > depending on NODES_SHIFT. > Right now, it goes the dynamic path whenever the

Re: [PATCH] mm/hugetlb: Get rid of NODEMASK_ALLOC

2019-04-02 Thread Mike Kravetz
On 4/2/19 6:34 AM, Oscar Salvador wrote: > NODEMASK_ALLOC is used to allocate a nodemask bitmap, ant it does it by ^ > first determining whether it should be allocated in the stack or dinamically

Re: [PATCH] mm/hugetlb: Get rid of NODEMASK_ALLOC

2019-04-02 Thread Oscar Salvador
On Tue, 2019-04-02 at 13:01 -0700, Andrew Morton wrote: > It took a bit of sleuthing to figure out that this patch applies to > Mike's "hugetlbfs: fix potential over/underflow setting node specific > nr_hugepages". Should they be folded together? I'm thinking not. Sorry Andrew, I should have

Re: [PATCH] mm/hugetlb: Get rid of NODEMASK_ALLOC

2019-04-02 Thread Mike Kravetz
On 4/2/19 1:01 PM, Andrew Morton wrote: > On Tue, 2 Apr 2019 15:34:15 +0200 Oscar Salvador wrote: > >> NODEMASK_ALLOC is used to allocate a nodemask bitmap, ant it does it by >> first determining whether it should be allocated in the stack or dinamically >> depending on NODES_SHIFT. >> Right

Re: [PATCH] mm/hugetlb: Get rid of NODEMASK_ALLOC

2019-04-02 Thread Andrew Morton
On Tue, 2 Apr 2019 15:34:15 +0200 Oscar Salvador wrote: > NODEMASK_ALLOC is used to allocate a nodemask bitmap, ant it does it by > first determining whether it should be allocated in the stack or dinamically > depending on NODES_SHIFT. > Right now, it goes the dynamic path whenever the

[PATCH] mm/hugetlb: Get rid of NODEMASK_ALLOC

2019-04-02 Thread Oscar Salvador
NODEMASK_ALLOC is used to allocate a nodemask bitmap, ant it does it by first determining whether it should be allocated in the stack or dinamically depending on NODES_SHIFT. Right now, it goes the dynamic path whenever the nodemask_t is above 32 bytes. Although we could bump it to a reasonable