Re: [PATCH] mm/hugetlb: fix error code in hugetlbfs_alloc_inode

2012-07-09 Thread David Rientjes
On Tue, 10 Jul 2012, Wanpeng Li wrote: > >>diff --git a/fs/hugetlbfs/inode.c b/fs/hugetlbfs/inode.c > >>index c4b85d0..79a0f33 100644 > >>--- a/fs/hugetlbfs/inode.c > >>+++ b/fs/hugetlbfs/inode.c > >>@@ -696,7 +696,7 @@ static struct inode *hugetlbfs_alloc_inode(struct > >>super_block *sb) > >>

Re: [PATCH] mm/hugetlb: fix error code in hugetlbfs_alloc_inode

2012-07-09 Thread Wanpeng Li
On Tue, Jul 10, 2012 at 09:09:10AM +0800, Gavin Shan wrote: >On Tue, Jul 10, 2012 at 09:03:04AM +0800, Wanpeng Li wrote: >>From: Wanpeng Li >> >>When kmem_cache_alloc fails alloc slab object from >>hugetlbfs_inode_cachep, return -ENOMEM in usual. But >>hugetlbfs_alloc_inode implementation has

Re: [PATCH] mm/hugetlb: fix error code in hugetlbfs_alloc_inode

2012-07-09 Thread Gavin Shan
On Tue, Jul 10, 2012 at 09:03:04AM +0800, Wanpeng Li wrote: >From: Wanpeng Li > >When kmem_cache_alloc fails alloc slab object from >hugetlbfs_inode_cachep, return -ENOMEM in usual. But >hugetlbfs_alloc_inode implementation has inconsitency >with it and returns NULL. Fix it to return -ENOMEM. >

[PATCH] mm/hugetlb: fix error code in hugetlbfs_alloc_inode

2012-07-09 Thread Wanpeng Li
From: Wanpeng Li When kmem_cache_alloc fails alloc slab object from hugetlbfs_inode_cachep, return -ENOMEM in usual. But hugetlbfs_alloc_inode implementation has inconsitency with it and returns NULL. Fix it to return -ENOMEM. Signed-off-by: Wanpeng Li --- fs/hugetlbfs/inode.c |2 +- 1

[PATCH] mm/hugetlb: fix error code in hugetlbfs_alloc_inode

2012-07-09 Thread Wanpeng Li
From: Wanpeng Li l...@linux.vnet.ibm.com When kmem_cache_alloc fails alloc slab object from hugetlbfs_inode_cachep, return -ENOMEM in usual. But hugetlbfs_alloc_inode implementation has inconsitency with it and returns NULL. Fix it to return -ENOMEM. Signed-off-by: Wanpeng Li

Re: [PATCH] mm/hugetlb: fix error code in hugetlbfs_alloc_inode

2012-07-09 Thread Gavin Shan
On Tue, Jul 10, 2012 at 09:03:04AM +0800, Wanpeng Li wrote: From: Wanpeng Li l...@linux.vnet.ibm.com When kmem_cache_alloc fails alloc slab object from hugetlbfs_inode_cachep, return -ENOMEM in usual. But hugetlbfs_alloc_inode implementation has inconsitency with it and returns NULL. Fix it to

Re: [PATCH] mm/hugetlb: fix error code in hugetlbfs_alloc_inode

2012-07-09 Thread Wanpeng Li
On Tue, Jul 10, 2012 at 09:09:10AM +0800, Gavin Shan wrote: On Tue, Jul 10, 2012 at 09:03:04AM +0800, Wanpeng Li wrote: From: Wanpeng Li l...@linux.vnet.ibm.com When kmem_cache_alloc fails alloc slab object from hugetlbfs_inode_cachep, return -ENOMEM in usual. But hugetlbfs_alloc_inode

Re: [PATCH] mm/hugetlb: fix error code in hugetlbfs_alloc_inode

2012-07-09 Thread David Rientjes
On Tue, 10 Jul 2012, Wanpeng Li wrote: diff --git a/fs/hugetlbfs/inode.c b/fs/hugetlbfs/inode.c index c4b85d0..79a0f33 100644 --- a/fs/hugetlbfs/inode.c +++ b/fs/hugetlbfs/inode.c @@ -696,7 +696,7 @@ static struct inode *hugetlbfs_alloc_inode(struct super_block *sb) p =