Re: [PATCH] mm/memcontrol: fix warning in mem_cgroup_page_lruvec()

2021-01-08 Thread Hugh Dickins
On Thu, 7 Jan 2021, Vlastimil Babka wrote: > On 1/4/21 6:03 AM, Hugh Dickins wrote: > > Boot a CONFIG_MEMCG=y kernel with "cgroup_disabled=memory" and you are > > met by a series of warnings from the VM_WARN_ON_ONCE_PAGE(!memcg, page) > > recently added to the inline mem_cgroup_page_lruvec(). > >

Re: [PATCH] mm/memcontrol: fix warning in mem_cgroup_page_lruvec()

2021-01-07 Thread Vlastimil Babka
On 1/4/21 6:03 AM, Hugh Dickins wrote: > Boot a CONFIG_MEMCG=y kernel with "cgroup_disabled=memory" and you are > met by a series of warnings from the VM_WARN_ON_ONCE_PAGE(!memcg, page) > recently added to the inline mem_cgroup_page_lruvec(). > > An earlier attempt to place that warning, in

Re: [PATCH] mm/memcontrol: fix warning in mem_cgroup_page_lruvec()

2021-01-06 Thread Baoquan He
On 01/06/21 at 11:35am, Andrew Morton wrote: > On Wed, 6 Jan 2021 14:49:35 +0800 Baoquan He wrote: > > > > Fixes: 9a1ac2288cf1 ("mm/memcontrol:rewrite mem_cgroup_page_lruvec()") > > > > ... > > > > Thanks for fixing this. We also encountered this issue in kdump kernel > > with the mainline 5.10

Re: [PATCH] mm/memcontrol: fix warning in mem_cgroup_page_lruvec()

2021-01-06 Thread Andrew Morton
On Wed, 6 Jan 2021 14:49:35 +0800 Baoquan He wrote: > > Fixes: 9a1ac2288cf1 ("mm/memcontrol:rewrite mem_cgroup_page_lruvec()") > > ... > > Thanks for fixing this. We also encountered this issue in kdump kernel > with the mainline 5.10 kernel since 'cgroup_disable=memory' is added. Wait.

Re: [PATCH] mm/memcontrol: fix warning in mem_cgroup_page_lruvec()

2021-01-06 Thread Andrew Morton
On Wed, 6 Jan 2021 14:49:35 +0800 Baoquan He wrote: > > --- 5.11-rc2/include/linux/memcontrol.h 2020-12-27 20:39:36.751923135 > > -0800 > > +++ linux/include/linux/memcontrol.h2021-01-03 19:38:24.822978559 > > -0800 > > @@ -665,7 +665,7 @@ static inline struct lruvec *mem_cgroup_ >

Re: [PATCH] mm/memcontrol: fix warning in mem_cgroup_page_lruvec()

2021-01-06 Thread Chris Down
Hugh Dickins writes: Boot a CONFIG_MEMCG=y kernel with "cgroup_disabled=memory" and you are met by a series of warnings from the VM_WARN_ON_ONCE_PAGE(!memcg, page) recently added to the inline mem_cgroup_page_lruvec(). An earlier attempt to place that warning, in mem_cgroup_lruvec(), had been

Re: [PATCH] mm/memcontrol: fix warning in mem_cgroup_page_lruvec()

2021-01-05 Thread Baoquan He
On 01/03/21 at 09:03pm, Hugh Dickins wrote: > Boot a CONFIG_MEMCG=y kernel with "cgroup_disabled=memory" and you are > met by a series of warnings from the VM_WARN_ON_ONCE_PAGE(!memcg, page) > recently added to the inline mem_cgroup_page_lruvec(). > > An earlier attempt to place that warning, in

Re: [PATCH] mm/memcontrol: fix warning in mem_cgroup_page_lruvec()

2021-01-04 Thread Roman Gushchin
> Boot a CONFIG_MEMCG=y kernel with "cgroup_disabled=memory" and you are > met by a series of warnings from the VM_WARN_ON_ONCE_PAGE(!memcg, page) > recently added to the inline mem_cgroup_page_lruvec(). > > An earlier attempt to place that warning, in mem_cgroup_lruvec(), had > been careful to

Re: [PATCH] mm/memcontrol: fix warning in mem_cgroup_page_lruvec()

2021-01-04 Thread Alex Shi
Reviewed-by: Alex Shi 在 2021/1/4 下午1:03, Hugh Dickins 写道: > Boot a CONFIG_MEMCG=y kernel with "cgroup_disabled=memory" and you are > met by a series of warnings from the VM_WARN_ON_ONCE_PAGE(!memcg, page) > recently added to the inline mem_cgroup_page_lruvec(). > > An earlier attempt to place

[PATCH] mm/memcontrol: fix warning in mem_cgroup_page_lruvec()

2021-01-03 Thread Hugh Dickins
Boot a CONFIG_MEMCG=y kernel with "cgroup_disabled=memory" and you are met by a series of warnings from the VM_WARN_ON_ONCE_PAGE(!memcg, page) recently added to the inline mem_cgroup_page_lruvec(). An earlier attempt to place that warning, in mem_cgroup_lruvec(), had been careful to do so after