Re: [PATCH] mm/memcontrol.c: fix another unused function warning

2019-10-02 Thread Michal Hocko
On Tue 01-10-19 09:36:24, Nick Desaulniers wrote: > On Tue, Oct 1, 2019 at 7:22 AM Arnd Bergmann wrote: > > > > Removing the mem_cgroup_id_get() stub function introduced a new warning > > of the same kind when CONFIG_MMU is disabled: > > > > mm/memcontrol.c:4929:13: error: unused function 'mem_cgr

Re: [PATCH] mm/memcontrol.c: fix another unused function warning

2019-10-02 Thread Michal Hocko
On Tue 01-10-19 10:40:05, Qian Cai wrote: > On Tue, 2019-10-01 at 16:22 +0200, Arnd Bergmann wrote: > > Removing the mem_cgroup_id_get() stub function introduced a new warning > > of the same kind when CONFIG_MMU is disabled: > > Shouldn't CONFIG_MEMCG depends on CONFIG_MMU instead? I wanted to d

Re: [PATCH] mm/memcontrol.c: fix another unused function warning

2019-10-01 Thread Qian Cai
On Tue, 2019-10-01 at 18:00 +0200, Arnd Bergmann wrote: > On Tue, Oct 1, 2019 at 4:40 PM Qian Cai wrote: > > > > On Tue, 2019-10-01 at 16:22 +0200, Arnd Bergmann wrote: > > > Removing the mem_cgroup_id_get() stub function introduced a new warning > > > of the same kind when CONFIG_MMU is disabled

Re: [PATCH] mm/memcontrol.c: fix another unused function warning

2019-10-01 Thread Nick Desaulniers
On Tue, Oct 1, 2019 at 7:22 AM Arnd Bergmann wrote: > > Removing the mem_cgroup_id_get() stub function introduced a new warning > of the same kind when CONFIG_MMU is disabled: > > mm/memcontrol.c:4929:13: error: unused function 'mem_cgroup_id_get_many' > [-Werror,-Wunused-function] > > Address th

Re: [PATCH] mm/memcontrol.c: fix another unused function warning

2019-10-01 Thread Arnd Bergmann
On Tue, Oct 1, 2019 at 4:40 PM Qian Cai wrote: > > On Tue, 2019-10-01 at 16:22 +0200, Arnd Bergmann wrote: > > Removing the mem_cgroup_id_get() stub function introduced a new warning > > of the same kind when CONFIG_MMU is disabled: > > Shouldn't CONFIG_MEMCG depends on CONFIG_MMU instead? Maybe.

Re: [PATCH] mm/memcontrol.c: fix another unused function warning

2019-10-01 Thread Qian Cai
On Tue, 2019-10-01 at 16:22 +0200, Arnd Bergmann wrote: > Removing the mem_cgroup_id_get() stub function introduced a new warning > of the same kind when CONFIG_MMU is disabled: Shouldn't CONFIG_MEMCG depends on CONFIG_MMU instead? > > mm/memcontrol.c:4929:13: error: unused function 'mem_cgroup_

[PATCH] mm/memcontrol.c: fix another unused function warning

2019-10-01 Thread Arnd Bergmann
Removing the mem_cgroup_id_get() stub function introduced a new warning of the same kind when CONFIG_MMU is disabled: mm/memcontrol.c:4929:13: error: unused function 'mem_cgroup_id_get_many' [-Werror,-Wunused-function] Address this using a __maybe_unused annotation. Note: alternatively, this co