Re: [PATCH] mm/memory_hotplug: Drop memory device reference after find_memory_block()

2019-04-11 Thread Michal Hocko
On Thu 11-04-19 13:18:07, David Hildenbrand wrote: > On 11.04.19 12:56, Michal Hocko wrote: > > On Thu 11-04-19 11:11:05, David Hildenbrand wrote: > >> On 11.04.19 10:41, Michal Hocko wrote: > >>> On Wed 10-04-19 12:14:55, David Hildenbrand wrote: > While current node handling is probably terr

Re: [PATCH] mm/memory_hotplug: Drop memory device reference after find_memory_block()

2019-04-11 Thread David Hildenbrand
On 11.04.19 12:56, Michal Hocko wrote: > On Thu 11-04-19 11:11:05, David Hildenbrand wrote: >> On 11.04.19 10:41, Michal Hocko wrote: >>> On Wed 10-04-19 12:14:55, David Hildenbrand wrote: While current node handling is probably terribly broken for memory block devices that span several n

Re: [PATCH] mm/memory_hotplug: Drop memory device reference after find_memory_block()

2019-04-11 Thread Michal Hocko
On Thu 11-04-19 11:11:05, David Hildenbrand wrote: > On 11.04.19 10:41, Michal Hocko wrote: > > On Wed 10-04-19 12:14:55, David Hildenbrand wrote: > >> While current node handling is probably terribly broken for memory block > >> devices that span several nodes (only possible when added during boot

Re: [PATCH] mm/memory_hotplug: Drop memory device reference after find_memory_block()

2019-04-11 Thread David Hildenbrand
On 11.04.19 10:41, Michal Hocko wrote: > On Wed 10-04-19 12:14:55, David Hildenbrand wrote: >> While current node handling is probably terribly broken for memory block >> devices that span several nodes (only possible when added during boot, >> and something like that should be blocked completely),

Re: [PATCH] mm/memory_hotplug: Drop memory device reference after find_memory_block()

2019-04-11 Thread Michal Hocko
On Wed 10-04-19 12:14:55, David Hildenbrand wrote: > While current node handling is probably terribly broken for memory block > devices that span several nodes (only possible when added during boot, > and something like that should be blocked completely), properly put the > device reference we obta

Re: [PATCH] mm/memory_hotplug: Drop memory device reference after find_memory_block()

2019-04-10 Thread Wei Yang
On Wed, Apr 10, 2019 at 12:14:55PM +0200, David Hildenbrand wrote: >While current node handling is probably terribly broken for memory block >devices that span several nodes (only possible when added during boot, >and something like that should be blocked completely), properly put the >device refer

Re: [PATCH] mm/memory_hotplug: Drop memory device reference after find_memory_block()

2019-04-10 Thread David Hildenbrand
On 10.04.19 14:28, Oscar Salvador wrote: > On Wed, Apr 10, 2019 at 12:14:55PM +0200, David Hildenbrand wrote: >> While current node handling is probably terribly broken for memory block >> devices that span several nodes (only possible when added during boot, >> and something like that should be bl

Re: [PATCH] mm/memory_hotplug: Drop memory device reference after find_memory_block()

2019-04-10 Thread Oscar Salvador
On Wed, Apr 10, 2019 at 12:14:55PM +0200, David Hildenbrand wrote: > While current node handling is probably terribly broken for memory block > devices that span several nodes (only possible when added during boot, > and something like that should be blocked completely), properly put the > device r

[PATCH] mm/memory_hotplug: Drop memory device reference after find_memory_block()

2019-04-10 Thread David Hildenbrand
While current node handling is probably terribly broken for memory block devices that span several nodes (only possible when added during boot, and something like that should be blocked completely), properly put the device reference we obtained via find_memory_block() to get the nid. Fixes: d0dc12