Re: [PATCH] mm/mmap.c: Remove redundent 'get_area' function pointer in get_unmapped_area()

2015-09-11 Thread Chen Gang
On 9/11/15 06:32, Andrew Morton wrote: > On Thu, 3 Sep 2015 12:14:51 +0800 gang.chen.5...@gmail.com wrote: > > size(1) says this generates more object code. And that probably means > slightly worse code. I didn't investigate, but probably the compiler > is now preparing those five args at two

Re: [PATCH] mm/mmap.c: Remove redundent 'get_area' function pointer in get_unmapped_area()

2015-09-11 Thread Chen Gang
On 9/11/15 06:32, Andrew Morton wrote: > On Thu, 3 Sep 2015 12:14:51 +0800 gang.chen.5...@gmail.com wrote: > > size(1) says this generates more object code. And that probably means > slightly worse code. I didn't investigate, but probably the compiler > is now preparing those five args at two

Re: [PATCH] mm/mmap.c: Remove redundent 'get_area' function pointer in get_unmapped_area()

2015-09-10 Thread Andrew Morton
On Thu, 3 Sep 2015 12:14:51 +0800 gang.chen.5...@gmail.com wrote: > From: Chen Gang > > Call the function pointer directly, then let code a bit simpler. > > ... > > --- a/mm/mmap.c > +++ b/mm/mmap.c > @@ -2012,10 +2012,8 @@ unsigned long > get_unmapped_area(struct file *file, unsigned long

Re: [PATCH] mm/mmap.c: Remove redundent 'get_area' function pointer in get_unmapped_area()

2015-09-10 Thread Andrew Morton
On Thu, 3 Sep 2015 12:14:51 +0800 gang.chen.5...@gmail.com wrote: > From: Chen Gang > > Call the function pointer directly, then let code a bit simpler. > > ... > > --- a/mm/mmap.c > +++ b/mm/mmap.c > @@ -2012,10 +2012,8 @@ unsigned long > get_unmapped_area(struct

Re: [PATCH] mm/mmap.c: Remove redundent 'get_area' function pointer in get_unmapped_area()

2015-09-08 Thread David Rientjes
On Sat, 5 Sep 2015, Chen Gang wrote: > > From a1bf4726f71d6d0394b41309944646fc806a8a0c Mon Sep 17 00:00:00 2001 > From: Chen Gang > Date: Sat, 5 Sep 2015 21:51:08 +0800 > Subject: [PATCH] mm/mmap.c: Remove redundent 'get_area' function pointer in > get_unmapped_area() >

Re: [PATCH] mm/mmap.c: Remove redundent 'get_area' function pointer in get_unmapped_area()

2015-09-08 Thread Chen Gang
On 9/7/15 20:41, Oleg Nesterov wrote: > On 09/05, Chen Gang wrote: >> >> From a1bf4726f71d6d0394b41309944646fc806a8a0c Mon Sep 17 00:00:00 2001 >> From: Chen Gang >> Date: Sat, 5 Sep 2015 21:51:08 +0800 >> Subject: [PATCH] mm/mmap.c: Remove redu

Re: [PATCH] mm/mmap.c: Remove redundent 'get_area' function pointer in get_unmapped_area()

2015-09-08 Thread Chen Gang
On 9/7/15 20:41, Oleg Nesterov wrote: > On 09/05, Chen Gang wrote: >> >> From a1bf4726f71d6d0394b41309944646fc806a8a0c Mon Sep 17 00:00:00 2001 >> From: Chen Gang <gang.chen.5...@gmail.com> >> Date: Sat, 5 Sep 2015 21:51:08 +0800 >> Subject: [PATCH] mm/mmap.

Re: [PATCH] mm/mmap.c: Remove redundent 'get_area' function pointer in get_unmapped_area()

2015-09-08 Thread David Rientjes
On Sat, 5 Sep 2015, Chen Gang wrote: > > From a1bf4726f71d6d0394b41309944646fc806a8a0c Mon Sep 17 00:00:00 2001 > From: Chen Gang <gang.chen.5...@gmail.com> > Date: Sat, 5 Sep 2015 21:51:08 +0800 > Subject: [PATCH] mm/mmap.c: Remove redundent 'get_area' function pointer i

Re: [PATCH] mm/mmap.c: Remove redundent 'get_area' function pointer in get_unmapped_area()

2015-09-07 Thread Oleg Nesterov
On 09/05, Chen Gang wrote: > > From a1bf4726f71d6d0394b41309944646fc806a8a0c Mon Sep 17 00:00:00 2001 > From: Chen Gang > Date: Sat, 5 Sep 2015 21:51:08 +0800 > Subject: [PATCH] mm/mmap.c: Remove redundent 'get_area' function pointer in > get_unmapped_area() > > Call the f

Re: [PATCH] mm/mmap.c: Remove redundent 'get_area' function pointer in get_unmapped_area()

2015-09-07 Thread Oleg Nesterov
On 09/05, Chen Gang wrote: > > From a1bf4726f71d6d0394b41309944646fc806a8a0c Mon Sep 17 00:00:00 2001 > From: Chen Gang <gang.chen.5...@gmail.com> > Date: Sat, 5 Sep 2015 21:51:08 +0800 > Subject: [PATCH] mm/mmap.c: Remove redundent 'get_area' function pointer in > get_

[PATCH] mm/mmap.c: Remove redundent 'get_area' function pointer in get_unmapped_area()

2015-09-05 Thread Chen Gang
>From a1bf4726f71d6d0394b41309944646fc806a8a0c Mon Sep 17 00:00:00 2001 From: Chen Gang Date: Sat, 5 Sep 2015 21:51:08 +0800 Subject: [PATCH] mm/mmap.c: Remove redundent 'get_area' function pointer in get_unmapped_area() Call the function pointer directly, then let code a bit simpler. Sig

[PATCH] mm/mmap.c: Remove redundent 'get_area' function pointer in get_unmapped_area()

2015-09-05 Thread Chen Gang
>From a1bf4726f71d6d0394b41309944646fc806a8a0c Mon Sep 17 00:00:00 2001 From: Chen Gang <gang.chen.5...@gmail.com> Date: Sat, 5 Sep 2015 21:51:08 +0800 Subject: [PATCH] mm/mmap.c: Remove redundent 'get_area' function pointer in get_unmapped_area() Call the function pointer directly,

[PATCH] mm/mmap.c: Remove redundent 'get_area' function pointer in get_unmapped_area()

2015-09-02 Thread gang . chen . 5i5j
From: Chen Gang Call the function pointer directly, then let code a bit simpler. Signed-off-by: Chen Gang --- mm/mmap.c | 12 ++-- 1 file changed, 6 insertions(+), 6 deletions(-) diff --git a/mm/mmap.c b/mm/mmap.c index 4db7cf0..39fd727 100644 --- a/mm/mmap.c +++ b/mm/mmap.c @@

[PATCH] mm/mmap.c: Remove redundent 'get_area' function pointer in get_unmapped_area()

2015-09-02 Thread gang . chen . 5i5j
From: Chen Gang Call the function pointer directly, then let code a bit simpler. Signed-off-by: Chen Gang --- mm/mmap.c | 12 ++-- 1 file changed, 6 insertions(+), 6 deletions(-) diff --git a/mm/mmap.c b/mm/mmap.c index