Re: [PATCH] mm/page_alloc: simplify kmem cgroup charge/uncharge code

2020-12-09 Thread Shakeel Butt
On Wed, Dec 9, 2020 at 8:29 AM Michal Hocko wrote: > > On Tue 08-12-20 09:12:23, Shakeel Butt wrote: > > +Michal Hocko > > > > Message starts at https://lkml.kernel.org/r/20201207142204.GA18516@rlk > > > > On Mon, Dec 7, 2020 at 10:08 PM Hui Su wrote: > > > > > > On Mon, Dec 07, 2020 at 09:28:46A

Re: [PATCH] mm/page_alloc: simplify kmem cgroup charge/uncharge code

2020-12-09 Thread Michal Hocko
On Tue 08-12-20 09:12:23, Shakeel Butt wrote: > +Michal Hocko > > Message starts at https://lkml.kernel.org/r/20201207142204.GA18516@rlk > > On Mon, Dec 7, 2020 at 10:08 PM Hui Su wrote: > > > > On Mon, Dec 07, 2020 at 09:28:46AM -0800, Shakeel Butt wrote: > > > On Mon, Dec 7, 2020 at 6:22 AM Hu

Re: [PATCH] mm/page_alloc: simplify kmem cgroup charge/uncharge code

2020-12-08 Thread Shakeel Butt
+Michal Hocko Message starts at https://lkml.kernel.org/r/20201207142204.GA18516@rlk On Mon, Dec 7, 2020 at 10:08 PM Hui Su wrote: > > On Mon, Dec 07, 2020 at 09:28:46AM -0800, Shakeel Butt wrote: > > On Mon, Dec 7, 2020 at 6:22 AM Hui Su wrote: > > > > The reason to keep __memcg_kmem_[un]charg

Re: [PATCH] mm/page_alloc: simplify kmem cgroup charge/uncharge code

2020-12-08 Thread Hui Su
On Mon, Dec 07, 2020 at 09:28:46AM -0800, Shakeel Butt wrote: > On Mon, Dec 7, 2020 at 6:22 AM Hui Su wrote: > > The reason to keep __memcg_kmem_[un]charge_page functions is that they > were called in the very hot path. Can you please check the performance > impact of your change and if the gener

Re: [PATCH] mm/page_alloc: simplify kmem cgroup charge/uncharge code

2020-12-07 Thread Shakeel Butt
On Mon, Dec 7, 2020 at 6:22 AM Hui Su wrote: > > Since the commit 60cd4bcd6238 ("memcg: localize memcg_kmem_enabled() > check"), we have supplied the api which users don't have to explicitly > check memcg_kmem_enabled(). > > Signed-off-by: Hui Su > --- > mm/page_alloc.c | 12 ++-- > 1 fi

Re: [External] [PATCH] mm/page_alloc: simplify kmem cgroup charge/uncharge code

2020-12-07 Thread Muchun Song
On Mon, Dec 7, 2020 at 10:22 PM Hui Su wrote: > > Since the commit 60cd4bcd6238 ("memcg: localize memcg_kmem_enabled() > check"), we have supplied the api which users don't have to explicitly > check memcg_kmem_enabled(). > > Signed-off-by: Hui Su Reviewed-by: Muchun Song > --- > mm/page_allo

[PATCH] mm/page_alloc: simplify kmem cgroup charge/uncharge code

2020-12-07 Thread Hui Su
Since the commit 60cd4bcd6238 ("memcg: localize memcg_kmem_enabled() check"), we have supplied the api which users don't have to explicitly check memcg_kmem_enabled(). Signed-off-by: Hui Su --- mm/page_alloc.c | 12 ++-- 1 file changed, 6 insertions(+), 6 deletions(-) diff --git a/mm/pa