Re: [PATCH] mm/pgtable: Move extern zero_pfn outside __HAVE_COLOR_ZERO_PAGE

2020-06-16 Thread David Hildenbrand
On 16.06.20 11:48, Anshuman Khandual wrote: > > > On 06/16/2020 01:09 PM, David Hildenbrand wrote: >> On 16.06.20 06:08, Anshuman Khandual wrote: >>> zero_pfn variable is required whether __HAVE_COLOR_ZERO_PAGE is enabled >> >> Why is that relevant for this patch? > > That just states how it is

Re: [PATCH] mm/pgtable: Move extern zero_pfn outside __HAVE_COLOR_ZERO_PAGE

2020-06-16 Thread Anshuman Khandual
On 06/16/2020 01:09 PM, David Hildenbrand wrote: > On 16.06.20 06:08, Anshuman Khandual wrote: >> zero_pfn variable is required whether __HAVE_COLOR_ZERO_PAGE is enabled > > Why is that relevant for this patch? That just states how it is organized right now wrt __HAVE_COLOR_ZERO_PAGE. > >>

Re: [PATCH] mm/pgtable: Move extern zero_pfn outside __HAVE_COLOR_ZERO_PAGE

2020-06-16 Thread David Hildenbrand
On 16.06.20 06:08, Anshuman Khandual wrote: > zero_pfn variable is required whether __HAVE_COLOR_ZERO_PAGE is enabled Why is that relevant for this patch? > or not. Also it should not really be declared individually in all functions > where it gets used. Just move the declaration outside, which

Re: [PATCH] mm/pgtable: Move extern zero_pfn outside __HAVE_COLOR_ZERO_PAGE

2020-06-15 Thread Anshuman Khandual
On 06/16/2020 09:38 AM, Anshuman Khandual wrote: > zero_pfn variable is required whether __HAVE_COLOR_ZERO_PAGE is enabled > or not. Also it should not really be declared individually in all functions > where it gets used. Just move the declaration outside, which also makes it > available for

[PATCH] mm/pgtable: Move extern zero_pfn outside __HAVE_COLOR_ZERO_PAGE

2020-06-15 Thread Anshuman Khandual
zero_pfn variable is required whether __HAVE_COLOR_ZERO_PAGE is enabled or not. Also it should not really be declared individually in all functions where it gets used. Just move the declaration outside, which also makes it available for other potential users. Cc: Arnd Bergmann Cc: