Re: [PATCH] mm/rmap: always do TTU_IGNORE_ACCESS

2020-11-10 Thread Hugh Dickins
On Fri, 6 Nov 2020, Shakeel Butt wrote: > On Thu, Nov 5, 2020 at 7:00 PM Hugh Dickins wrote: > > > > I don't know why this was addressed to me in particular (easy to imagine > > I've made a mod at some time that bears on this, but I haven't found it); > > but have spent longer considering the patc

Re: [PATCH] mm/rmap: always do TTU_IGNORE_ACCESS

2020-11-06 Thread Shakeel Butt
On Thu, Nov 5, 2020 at 7:00 PM Hugh Dickins wrote: > > I don't know why this was addressed to me in particular (easy to imagine > I've made a mod at some time that bears on this, but I haven't found it); > but have spent longer considering the patch than I should have done - > apologies to everyon

Re: [PATCH] mm/rmap: always do TTU_IGNORE_ACCESS

2020-11-05 Thread Hugh Dickins
I don't know why this was addressed to me in particular (easy to imagine I've made a mod at some time that bears on this, but I haven't found it); but have spent longer considering the patch than I should have done - apologies to everyone else I should be replying to. On Wed, 4 Nov 2020, Shakeel B

Re: [PATCH] mm/rmap: always do TTU_IGNORE_ACCESS

2020-11-05 Thread Johannes Weiner
On Wed, Nov 04, 2020 at 03:19:28PM -0800, Shakeel Butt wrote: > Since the commit 369ea8242c0f ("mm/rmap: update to new mmu_notifier > semantic v2"), the code to check the secondary MMU's page table access > bit is broken for !(TTU_IGNORE_ACCESS) because the page is unmapped from > the secondary MMU

[PATCH] mm/rmap: always do TTU_IGNORE_ACCESS

2020-11-04 Thread Shakeel Butt
Since the commit 369ea8242c0f ("mm/rmap: update to new mmu_notifier semantic v2"), the code to check the secondary MMU's page table access bit is broken for !(TTU_IGNORE_ACCESS) because the page is unmapped from the secondary MMU's page table before the check. More specifically for those secondary