Re: [PATCH] mm/slub: Switch slub_debug kernel option to early_param to avoid boot panic

2013-11-07 Thread Christoph Lameter
There is still something not optimal with the patch since it would disable debuggin on the kmalloc stack. Ccheck name for NULL only if slub_debug_slabs. Subject: slub: Handle NULL parameter in kmem_cache_flags V2 V1->V2 - flags need to be applied regardless if !slub_debug_slabs kmem_cache_flag

Re: [PATCH] mm/slub: Switch slub_debug kernel option to early_param to avoid boot panic

2013-11-07 Thread Christoph Lameter
On Thu, 7 Nov 2013, Andreas Herrmann wrote: > And for sake of completeness. Here is some debug output with a kernel > that had your "slub: Handle NULL parameter in kmem_cache_flags" patch > applied. And of course there were a couple of unnamed slabs: > > ... > .bss : 0xc089fd80 - 0xc094

Re: [PATCH] mm/slub: Switch slub_debug kernel option to early_param to avoid boot panic

2013-11-07 Thread Andreas Herrmann
On Thu, Nov 07, 2013 at 09:27:32AM +0100, Andreas Herrmann wrote: > On Wed, Nov 06, 2013 at 04:38:10PM -0500, Christoph Lameter wrote: > > On Wed, 6 Nov 2013, Andreas Herrmann wrote: > > > > > Would be nice, if your patch is pushed upstream asap. > > > > Ok so this is a > > > > Tested-by: Andrea

Re: [PATCH] mm/slub: Switch slub_debug kernel option to early_param to avoid boot panic

2013-11-07 Thread Andreas Herrmann
On Wed, Nov 06, 2013 at 04:38:10PM -0500, Christoph Lameter wrote: > On Wed, 6 Nov 2013, Andreas Herrmann wrote: > > > Would be nice, if your patch is pushed upstream asap. > > Ok so this is a > > Tested-by: Andreas Herrmann > > I think? Yes. > BTW Calxeda is a great product. Hope you get 64

Re: [PATCH] mm/slub: Switch slub_debug kernel option to early_param to avoid boot panic

2013-11-06 Thread Christoph Lameter
On Wed, 6 Nov 2013, Andreas Herrmann wrote: > Would be nice, if your patch is pushed upstream asap. Ok so this is a Tested-by: Andreas Herrmann I think? BTW Calxeda is a great product. Hope you get 64 bit running soon. -- To unsubscribe from this list: send the line "unsubscribe linux-kernel

Re: [PATCH] mm/slub: Switch slub_debug kernel option to early_param to avoid boot panic

2013-11-06 Thread Andreas Herrmann
On Wed, Nov 06, 2013 at 09:34:29PM +0100, Andreas Herrmann wrote: > On Wed, Nov 06, 2013 at 08:54:17PM +0100, Andreas Herrmann wrote: > > On Wed, Nov 06, 2013 at 02:16:33PM -0500, Christoph Lameter wrote: > > > On Wed, 6 Nov 2013, Andreas Herrmann wrote: > > > > > > > When I've used slub_debug ker

Re: [PATCH] mm/slub: Switch slub_debug kernel option to early_param to avoid boot panic

2013-11-06 Thread Andreas Herrmann
On Wed, Nov 06, 2013 at 08:54:17PM +0100, Andreas Herrmann wrote: > On Wed, Nov 06, 2013 at 02:16:33PM -0500, Christoph Lameter wrote: > > On Wed, 6 Nov 2013, Andreas Herrmann wrote: > > > > > When I've used slub_debug kernel option (e.g. > > > "slub_debug=,skbuff_fclone_cache" or similar) on a de

Re: [PATCH] mm/slub: Switch slub_debug kernel option to early_param to avoid boot panic

2013-11-06 Thread Andreas Herrmann
On Wed, Nov 06, 2013 at 02:16:33PM -0500, Christoph Lameter wrote: > On Wed, 6 Nov 2013, Andreas Herrmann wrote: > > > When I've used slub_debug kernel option (e.g. > > "slub_debug=,skbuff_fclone_cache" or similar) on a debug session I've > > seen a panic like: > > Hmmm.. That looks like its due

Re: [PATCH] mm/slub: Switch slub_debug kernel option to early_param to avoid boot panic

2013-11-06 Thread Andreas Herrmann
On Wed, Nov 06, 2013 at 02:16:33PM -0500, Christoph Lameter wrote: > On Wed, 6 Nov 2013, Andreas Herrmann wrote: > > > When I've used slub_debug kernel option (e.g. > > "slub_debug=,skbuff_fclone_cache" or similar) on a debug session I've > > seen a panic like: > > Hmmm.. That looks like its due

Re: [PATCH] mm/slub: Switch slub_debug kernel option to early_param to avoid boot panic

2013-11-06 Thread Christoph Lameter
On Wed, 6 Nov 2013, Andreas Herrmann wrote: > When I've used slub_debug kernel option (e.g. > "slub_debug=,skbuff_fclone_cache" or similar) on a debug session I've > seen a panic like: Hmmm.. That looks like its due to some slabs not having names during early boot. kmem_cache_flags is called with

[PATCH] mm/slub: Switch slub_debug kernel option to early_param to avoid boot panic

2013-11-06 Thread Andreas Herrmann
When I've used slub_debug kernel option (e.g. "slub_debug=,skbuff_fclone_cache" or similar) on a debug session I've seen a panic like: Highbank #setenv bootargs console=ttyAMA0 root=/dev/sda2 kgdboc.kgdboc=ttyAMA0,115200 slub_debug=,kmalloc-4096 earlyprintk=ttyAMA0 ... Unable to handle ker